feat: CMD-143 deprecate most CMS document style class names#355
Merged
Conversation
I combined styles that are still used into `s-guide-doc.css`. I deprecated the remaining classes. Clients will have redundant stlyes on guide docs until they stop using: - s-document - s-inline-dl - u-nested-text-content The following class is still used: - s-guide-doc
github-actions
Bot
added
the
feature
1 task
wesleyboar
added a commit
that referenced
this pull request
Jul 24, 2024
wesleyboar
added a commit
that referenced
this pull request
Jul 24, 2024
* chore: v2.27.1 * build: v2.27.1 #355 (CMD-43) * build: v2.27.1
wesleyboar
added a commit
to TACC/Core-CMS
that referenced
this pull request
Jul 21, 2026
## Overview / Changes - Delete guide templates. - Do not use deprecated doc styles. ## Status - [x] update 3dem, Frontera, CEP to not use the templates - ~~test branch on 3dem, Frontera, CEP~~ - ~~update all other CMS sites~~ No sites use templates now. If I am wrong, let's fall-forward. ## Related - [CMD-143](https://tacc-main.atlassian.net/browse/CMD-143) follow-up - requires TACC/Core-CMS-Resources#199 - requires TACC/Core-Styles#355 - can be delayed until v5 because of #886 ## Testing > [!WARNING] > Untested Verify zero Core-CMS websites use these specific templates by changing all pages that use "Guide: …" to use "Guide" (or "Inherit from …"). ## UI Skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Deprecate these classes:
s-documents-inline-dlu-nested-text-contentClients should remove them and use only
.s-guide-docwrapper.Update this class to take over:
s-guide-docAdded styles from deprecated classes but used markup in selectors.
Related
Changes
s-guide-doc)Testing & UI
Skipped.