Skip to content

feat: bootstrap4 media link#621

Merged
wesleyboar merged 4 commits into
mainfrom
feat/bootstrap4-media-link
Apr 1, 2026
Merged

feat: bootstrap4 media link#621
wesleyboar merged 4 commits into
mainfrom
feat/bootstrap4-media-link

Conversation

@wesleyboar

Copy link
Copy Markdown
Member

Important

This is the missing commit from #620.

Add .media.media-link (gap + vertical centering), import in core-styles.bootstrap4.css, and Fractal pattern with readme and demo layout.

Made-with: Cursor
The styles I reference for this from CMS admin did not center
@wesleyboar
wesleyboar merged commit 010b311 into main Apr 1, 2026
@wesleyboar
wesleyboar deleted the feat/bootstrap4-media-link branch April 1, 2026 19:55
@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Fix bootstrap4 media-link alignment: replace center-align with top margin

✨ Enhancement 🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Replace align-items: center with top margin on non-body media elements
• Update .media-link styles for better Django CMS editor compatibility
• Propagate CSS changes to dist files for bootstrap4 media component
Diagram
flowchart LR
  src["src/lib/_imports/bootstrap4/components/media.css"]
  dist_media["dist/bootstrap4/components/media.css"]
  dist_core["dist/core-styles.bootstrap4.css"]
  src -- "remove align-items:center, add margin-top on non-body" --> dist_media
  src -- "propagate changes" --> dist_core
Loading

Grey Divider

File Changes

1. src/lib/_imports/bootstrap4/components/media.css ✨ Enhancement +3/-1

Replace center-align with top margin for media-link

• Removed align-items: center from .media-link
• Added new rule .media-link > :not(.media-body) with margin-top: 0.5rem for vertical spacing

src/lib/_imports/bootstrap4/components/media.css


2. dist/bootstrap4/components/media.css ✨ Enhancement +1/-1

Update compiled media-link CSS dist file

• Updated compiled CSS to reflect source changes
• Replaced align-items:center with margin-top:.5rem on non-body children

dist/bootstrap4/components/media.css


3. dist/core-styles.bootstrap4.css ✨ Enhancement +1/-1

Propagate media-link style fix to core bootstrap4 bundle

• Updated bundled CSS to reflect new .media-link styles
• Removed align-items:center, added .media-link>:not(.media-body){margin-top:.5rem}

dist/core-styles.bootstrap4.css


Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

Grey Divider

Looking for bugs?

Check back in a few minutes. An AI review agent is analyzing this pull request.

Grey Divider

Qodo Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant