feat: tup-463 migrate css to core#344
Merged
Merged
Conversation
wesleyboar
changed the title
wesleyboar
changed the title
* feat: tup-619 c-content block migration * removed content-block import
* migrated c-update to core-styles * removed c-update import
* feat: tup-624: added generics/attributes to demo * migrated rest of attributes.css to core-styles * removed unnecessary comments in css file for c-button
* getting rid of django.cms.blog.app.item.css * removing the import for django.cms.blog.app.item.css
Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>
Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>
wesleyboar
marked this pull request as ready for review
November 3, 2023 23:18
wesleyboar
commented
Nov 3, 2023
WARNING: v2.17.3 causes login form field bug.
No need for u-highlight per jira ticket Co-authored-by: Wesley B <62723358+wesleyboar@users.noreply.github.com>
Co-authored-by: Wesley Bomar <wbomar@tacc.utexas.edu>
* I believe this has already been merged into core-styles... Padding and Margin seem to be available on prod * remove import of core-styles o-heading-steps.css
* feat/tup-633: Migrate lightgallery to core-cms * delete unnecessary import of django.cms.picture.css
* feat/tup-629: delete footer Footer is already in core-styles and cms * remove unnecessary imports
* bug/tup-650: Remove padding-block from cms * adjusted comments to relative code blocks
* fix: tup-654 use c-form--login from core-styles * chore: tup-654 remove redundant `c-form` classname
Some Core-Styles were loaded via CDN, cuz CMS did not have latest yet. Now CMS has much more recent Core-Styles, so use them. Do not duplicate.
* chore: tup-463 remove temp. core-styles imports Some Core-Styles were loaded via CDN, cuz CMS did not have latest yet. Now CMS has much more recent Core-Styles, so use them. Do not duplicate. * chore: tup-463 delete css modules mimicking core Some Core-Styles CSS was added after TUP login form was developed. Now that it is available, TUP lofin form can use it. Less module CSS! * style: npx nx format:write
Some Core-Styles CSS was added after TUP login page was developed. Now that it is available, TUP login page can use it. Less module CSS!
Member
Author
|
Warning MFA Update: Fixed by #379. |
* hotfix: tup-654 mfa's c-nav not showing a pipe 1. There should be a pipe (border) between nav links. 2. The `c-button--as-link` nav link's pipe was present but invisible. 3. c-button x-truncate `overflow: hidden` overwrote `overflow: visible`. 4. It should be the other way around. 5. Composing c-button from dist/ includes entire file into global scope. 6. Isntead, compose from src, to get only what is necessary. * hotfix: tup-654 mfa's c-nav not showing a pipe 1. There should be a pipe (border) between nav links. 2. The `c-button--as-link` nav link's pipe was present but invisible. 3. c-button x-truncate `overflow: hidden` overwrote `overflow: visible`. 4. It should be the other way around. 5. Importing c-form--login without layer gave it precedence. 6. Instead, import into base layer, so all Core-Styles are in base.
The core-styles.portal.css already includes cortal.icon.css.
* hotfix: tup-658 form login title too small * docs: idea, Core-Styles elements/headings--portal
TACC/Core-CMS#678 (latest as of now)
wesleyboar
changed the title
* chore: search dropdown should use var for white * fix: footer buttons should not have width limit * refactor: deprecate `<small>` in footer buttons * fix!: do not let search styles bleed beyond search Requires an `id="tacc-google-search` wrapper. * fix: remove unnecessary style The only `<h1>` on the page is "Search" text provided by CMS not Google. * docs: explain strange, complex search css selector * fix: core-styles v2.22.0 to v2.22.1 * chore: core-styles v2.22.1 to v2.22.2
wesleyboar
requested review from
R-Tomas-Gonzalez,
jarosenb and
sophia-massie
and removed request for
jarosenb
November 28, 2023 00:18
sophia-massie
approved these changes
Nov 29, 2023
sophia-massie
left a comment
sophia-massie
left a comment
Collaborator
There was a problem hiding this comment.
Looks great! Thank you
Member
Author
|
Merging with one approval, because:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Migrate CSS from here to Core-CMS and Core-Styles.
Status
Tested many times. Fixed many bugs. Ready for review.
Details
Related
Changes
Testing & UI
This is mostly moving styles and fixing bugs, so UI looks the same. But there are some differences.
See merged PRs to
feat/tup-463branch before 2023-12-01.