Fix: false validation errors on solution source#70
Open
zekelinAlex wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workspace validator reported errors and warnings on valid solution source. Two causes: some file formats had no schema, and the JSON validator checked every json file against the flow schema.
Added XSD schemas for formats that had none: CMT data exports (data.xml, data_schema.xml), [Content_Types].xml, ImportConfig.xml, catalog.xml and catalogassignments.xml, map.xml, CanvasApp meta.xml, and PCF control manifests.
Extended existing schemas to accept what real exports contain: SolutionAction and reordered rule blocks in ribbon diffs, solutionaction and Descriptions labels in forms, repeated IsCustomizable in workflows, and msdyn_dataflows in Customizations.xml. These changes only widen what's accepted, so they remove findings without adding new ones. Verified against the PCT and PCF reference solutions: the set of findings is a strict subset of before.
JSON validation now selects the schema by file location: the flow schema applies only to json under Workflows/, so other json (package.json, tsconfig.json, environment variable values) is no longer checked against it.
Validation messages now include the stage that produced them ([Schema], [JSON], [GUID], [Model]).
Duplicate GUID detection is now scoped by component identity (via the component registry), so
the same component declared across solution layers is no longer flagged as a duplicate of itself.