-
Notifications
You must be signed in to change notification settings - Fork 31
Refactor profile picture image cropper #3060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samuelwei
wants to merge
14
commits into
develop
Choose a base branch
from
refactor-image-cropper
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0804f85
Replace vue-cropperjs with cropperjs
samuelwei 5eca95d
Refactor image copper style
samuelwei 964d2cf
Refactor file size validation, show file size and allowed formats in …
samuelwei f0bcd9b
Add keyboard support
samuelwei d27ed69
Fix locale key
samuelwei 3166796
Fix code style
samuelwei 53216fa
Prevent event propagation
samuelwei e88a676
Improve file size calc.
samuelwei 8f8a108
Fix tests
samuelwei e4be70e
Fix tests
samuelwei 386f632
Fix cs
samuelwei 0ba9fe9
Adjust tests
samuelwei f213acd
Skip cropper initialisation if dialog is closed
samuelwei 48e1aec
Update changelog
samuelwei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| @import "cropperjs/dist/cropper.css"; | ||
|
|
||
| .cropper-container { | ||
| overflow: hidden; | ||
|
|
||
| img { | ||
| display: block; | ||
|
|
||
| /* This rule is very important, please don't ignore this */ | ||
| max-width: 100%; | ||
| } | ||
|
|
||
| .cropper-view-box, | ||
| .cropper-face { | ||
| border-radius: 50%; | ||
| } | ||
|
|
||
| .cropper-view-box { | ||
| outline: 0; | ||
| } | ||
|
|
||
| .cropper-face { | ||
| background-color: transparent; | ||
| opacity: 1; | ||
| border: 1px dashed #fff; | ||
| } | ||
|
|
||
| .cropper-line { | ||
| display: none; | ||
| } | ||
|
|
||
| .cropper-point { | ||
| background-color: #fff; | ||
| border-radius: 50%; | ||
| border: 1px solid #767676; | ||
| opacity: 1; | ||
| width: 10px; | ||
| height: 10px; | ||
| } | ||
|
|
||
| .cropper-point.point-n, | ||
| .cropper-point.point-w, | ||
| .cropper-point.point-s, | ||
| .cropper-point.point-e, | ||
| .cropper-point.point-se::before { | ||
| display: none; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edge case: empty
BBB_ALLOWED_FILE_MIMESproduces['']instead of[].If an operator sets
BBB_ALLOWED_FILE_MIMES=(empty),explode(',', '')returns[''], which will propagate an empty entry intoFile::types()/File::extensions()on the backend and into the frontendaccept="."/ "Allowed formats: " display. Consider normalizing and trimming entries, and dropping empties.🛡️ Suggested hardening
📝 Committable suggestion
🤖 Prompt for AI Agents