Skip to content

fix: restore actor weights after loading OPD teacher checkpoint #1903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
canlin03 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −0
Open

fix: restore actor weights after loading OPD teacher checkpoint #1903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions slime/backends/megatron_utils/actor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,11 @@ def init(
# Load teacher model for Megatron-based on-policy distillation
if with_opd_teacher:
self.load_other_checkpoint("teacher", args.opd_teacher_load)
# Restore actor weights so update_weights() pushes the student (not teacher) to sglang.
# Without offload_train the generic recovery below is skipped, leaving self.model
# in teacher state and causing step-0 rollouts/evals to run with the teacher model.
if not self.args.offload_train:
self._switch_model("actor")

if self.args.keep_old_actor:
# Load old_actor checkpoint
Expand Down