Skip to content

Fix(router): handle debug.getinfo returning nil for non-Lua functions #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PlumBlossomMaid wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix(router): handle debug.getinfo returning nil for non-Lua functions #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions lua/express/router/layer.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,26 +41,28 @@ LAYER_MT.__index = LAYER_MT

-- Handle the error for the layer.
function LAYER_MT:handle_error(err, req, res, next)
local fn = self.handle
if debug.getinfo(fn, "Su").nparams ~= 4 then
-- not a standard error handler
return next(err)
end

local ok, er = pcall(fn, err, req, res, next)
if not ok then next(er) end
local fn = self.handle
local info = debug.getinfo(fn, "Su")
if not info or not info.nparams or info.nparams ~= 4 then
-- not a standard error handler
return next(err)
end

local ok, er = pcall(fn, err, req, res, next)
if not ok then next(er) end
end

-- Handle the request for the layer.
function LAYER_MT:handle_request(req, res, next)
local fn = self.handle
if debug.getinfo(fn, "Su").nparams > 3 then
-- not a standard error handler
return next()
end

local ok, err = pcall(fn, req, res, next)
if not ok then next(err) end -- если ошибка в app:get() хендлере, то не останавливаемся, а идем к следующему, передавая ошибку дальше
local fn = self.handle
local info = debug.getinfo(fn, "Su")
if info and info.nparams and info.nparams > 3 then
-- not a standard request handler
return next()
end

local ok, err = pcall(fn, req, res, next)
if not ok then next(err) end
end

-- Check if this route matches `path`, if so populate `.params`.
Expand Down