Feat/root claim in wallet change default bittensor validator - #1407
Open
UrbanWill wants to merge 5 commits into
Open
Feat/root claim in wallet change default bittensor validator#1407UrbanWill wants to merge 5 commits into
UrbanWill wants to merge 5 commits into
Conversation
Root subnet (netuid 0) rewards can't be claimed from the portal. Render a Claim button in the claim column for root stakes that opens the Talisman wallet download page, with a tooltip explaining where to claim.
alecdwm
previously approved these changes
Aug 27, 2026
- postcss ^8.5.19 -> ^8.5.26: fixes GHSA-fxqj-rqcc-2cmp (arbitrary .map read via attacker-controlled sourceMappingURL when is unset). - eslint ^9.2.0 -> ^9.39.5: move to latest supported 9.x. Full clear of the deprecation advisory needs eslint 10, blocked upstream until eslint-plugin-react publishes v10 peer support.
alecdwm
previously approved these changes
Aug 27, 2026
Bittensor reward totals were derived by paginating every delegation event for the nominator, then summed and shown in the "Total rewards (all time)" column on the staking positions page. Remove that calculation and render nothing in the rewards column for bittensor rows: - Delete useGetRewardsByNominator and its only-consumers useGetInfiniteDelegationEvents and useGetDTaoStakedBalances. - Drop rewards/rewardsFormatted and isRewardsLoading from useStake/StakeItem. - Stop passing rewards, fiatRewards, isRewardsLoading from StakeItemRow; the shared recipe auto-hides the column when both are absent. Scoped to subtensor only; other providers keep their reward totals.
prury
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bittensor staking: remark constant, root claim guidance, rewards removal + dep bumps
Summary
Changes to the Bittensor (subtensor) staking flow in the portal, plus a dependency audit fix:
TALISMAN_STAKE_REMARKconstant ('paprika005') and use it for everyremarkWithEventcall, replacing the hardcoded'talisman-bittensor'string.0) rewards can't be claimed from the portal, so the positions table now renders a Claim button that points users to the Talisman wallet.postcssandeslint.Changes
Stake remark constant
TALISMAN_STAKE_REMARK = 'paprika005'inconstants.ts.remarkWithEvent('talisman-bittensor')calls withremarkWithEvent(TALISMAN_STAKE_REMARK)informs.tsanduseMoveStake.ts.Single source of truth for the on-chain remark tag, so future changes touch one line.
Root stake claim button
TALISMAN_WALLET_DOWNLOAD_URL = 'https://talisman.xyz/download'inconstants.ts.StakeItemRow, render aclaimButtononly for root stakes (netuid === ROOT_NETUID):Claimbutton with anInfoleading icon.noopener,noreferrer).Remove reward calculations for bittensor positions
Bittensor reward totals were derived by paginating every delegation event for the nominator, then summed and shown in the "Total rewards (all time)" column. Removed entirely; the column now renders nothing for bittensor rows.
useGetRewardsByNominatorand its only-consumersuseGetInfiniteDelegationEventsanduseGetDTaoStakedBalances.rewards/rewardsFormattedfields andisRewardsLoadingfromuseStake/StakeItem.rewards,fiatRewards,isRewardsLoadingfromStakeItemRow; the sharedStakePositionrecipe auto-hides the column when both are absent (shouldRenderTotalRewards = props.rewards || props.fiatRewards).Scoped to subtensor only — other providers (nom pools, dApp staking, validators, Lido, seek) keep their reward totals, and the shared recipe is untouched.
Dependency audit fixes
postcss^8.5.19→^8.5.26— fixes GHSA-fxqj-rqcc-2cmp (arbitrary.mapread via attacker-controlledsourceMappingURLwhenfromis unset).eslint^9.2.0→^9.39.5— move to the latest supported 9.x.Note: the eslint deprecation advisory only fully clears on eslint 10, which is currently blocked upstream —
eslint-plugin-react(latest 7.37.5) declares peer support only up to^9.7. Held at latest 9.x until it ships v10 support.Testing
tsc --noEmitpasses.