Skip to content

[fix]: prefer node_modules over stale PnP state#122

Merged
LadyBluenotes merged 3 commits intomainfrom
pnp-fix
Apr 24, 2026
Merged

[fix]: prefer node_modules over stale PnP state#122
LadyBluenotes merged 3 commits intomainfrom
pnp-fix

Conversation

@LadyBluenotes
Copy link
Copy Markdown
Member

  • Fixes intent list when stale Yarn PnP files exist alongside project node_modules, especially Bun node_modules/.bun installs.
  • Defers .pnp.cjs setup until node_modules is absent, so project node_modules scanning stays isolated from stale PnP state.
  • Adds regression coverage for mixed .pnp.cjs + Bun-style node_modules/.bun

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

Warning

Rate limit exceeded

@LadyBluenotes has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 6 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 59 minutes and 6 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 49fcb09f-c034-4c07-8470-da243462c9c8

📥 Commits

Reviewing files that changed from the base of the PR and between ce6d7dd and c33316f.

📒 Files selected for processing (6)
  • .changeset/violet-lies-hide.md
  • docs/cli/intent-list.md
  • docs/overview.md
  • packages/intent/README.md
  • packages/intent/src/scanner.ts
  • packages/intent/tests/scanner.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pnp-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 24, 2026

View your CI Pipeline Execution ↗ for commit c33316f

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 2s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-24 18:01:10 UTC

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 24, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@tanstack/intent@122

commit: c33316f

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 24, 2026

Merging this PR will not alter performance

✅ 3 untouched benchmarks


Comparing pnp-fix (c33316f) with main (8377f37)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (ce6d7dd) during the generation of this report, so 8377f37 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@LadyBluenotes LadyBluenotes merged commit af31cf2 into main Apr 24, 2026
7 checks passed
@LadyBluenotes LadyBluenotes deleted the pnp-fix branch April 24, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant