chore(deps): update Rsbuild related deps to v2.0.1#7245
Open
chenjiahan wants to merge 2 commits intoTanStack:mainfrom
Open
chore(deps): update Rsbuild related deps to v2.0.1#7245chenjiahan wants to merge 2 commits intoTanStack:mainfrom
chenjiahan wants to merge 2 commits intoTanStack:mainfrom
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (20)
✅ Files skipped from review due to trivial changes (19)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR updates rsbuild/rspack-related devDependency version ranges across multiple e2e projects, examples, and core packages — primarily bumping Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
View your CI Pipeline Execution ↗ for commit 1f97927
☁️ Nx Cloud last updated this comment at |
Contributor
Bundle Size Benchmarks
Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/react-start/package.json (1)
167-185:⚠️ Potential issue | 🟠 MajorLikely swapped version bump between
peerDependenciesanddevDependencies.Here
peerDependencies["@rsbuild/core"]was tightened from^2.0.0to^2.0.1whiledevDependencies["@rsbuild/core"]remains at^2.0.0. In every other package in this PR the opposite pattern is used (devDep moves to^2.0.1, peerDep stays at^2.0.0) — seepackages/vue-start/package.jsonlines 124/133,packages/solid-start/package.jsonlines 124/131, andpackages/start-plugin-core/package.jsonlines 100/108.Tightening only the peer range forces all downstream consumers to upgrade to 2.0.1 for a patch-level fix, while the package itself is still developed/tested against 2.0.0 locally. This looks like an accidental swap.
🛠 Proposed fix to mirror the pattern used by sibling packages
"peerDependencies": { - "@rsbuild/core": "^2.0.1", + "@rsbuild/core": "^2.0.0", "react": ">=18.0.0 || >=19.0.0", "react-dom": ">=18.0.0 || >=19.0.0", "vite": ">=7.0.0" }, ... "devDependencies": { - "@rsbuild/core": "^2.0.0", + "@rsbuild/core": "^2.0.1", "@tanstack/intent": "^0.0.14", "@types/node": ">=20" },🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@packages/react-start/package.json` around lines 167 - 185, The peer/dev version for `@rsbuild/core` was likely swapped: change peerDependencies["@rsbuild/core"] back to "^2.0.0" and update devDependencies["@rsbuild/core"] to "^2.0.1" so the package is developed/tested against the newer dev version while keeping the peer range unchanged (adjust the values in package.json where peerDependencies["@rsbuild/core"] and devDependencies["@rsbuild/core"] are defined).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@packages/react-start/package.json`:
- Around line 167-185: The peer/dev version for `@rsbuild/core` was likely
swapped: change peerDependencies["@rsbuild/core"] back to "^2.0.0" and update
devDependencies["@rsbuild/core"] to "^2.0.1" so the package is developed/tested
against the newer dev version while keeping the peer range unchanged (adjust the
values in package.json where peerDependencies["@rsbuild/core"] and
devDependencies["@rsbuild/core"] are defined).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3493967d-7da2-4aa9-8a3d-19994a45b2fb
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (20)
e2e/react-router/rspack-basic-file-based/package.jsone2e/react-router/rspack-basic-virtual-named-export-config-file-based/package.jsone2e/react-start/basic/package.jsone2e/react-start/custom-server-rsbuild/package.jsone2e/react-start/hmr/package.jsone2e/react-start/import-protection/package.jsone2e/react-start/rsc/package.jsone2e/react-start/server-functions/package.jsone2e/solid-router/rspack-basic-file-based/package.jsone2e/solid-router/rspack-basic-virtual-named-export-config-file-based/package.jsone2e/solid-start/basic/package.jsone2e/vue-router/rspack-basic-file-based/package.jsone2e/vue-router/rspack-basic-virtual-named-export-config-file-based/package.jsone2e/vue-start/basic/package.jsonexamples/react/quickstart-rspack-file-based/package.jsonexamples/solid/quickstart-rspack-file-based/package.jsonpackages/react-start/package.jsonpackages/solid-start/package.jsonpackages/start-plugin-core/package.jsonpackages/vue-start/package.json
There was a problem hiding this comment.
Pull request overview
Updates the monorepo’s Rsbuild toolchain dependencies to pick up Rsbuild 2.0.1 (notably the dev-server URL printing fix needed for SSR setups when HTML generation is disabled), and refreshes related Rsbuild plugins across internal packages, examples, and e2e fixtures.
Changes:
- Bump
@rsbuild/coreusage across packages/examples/e2e projects to^2.0.1. - Update select Rsbuild plugins (React/Solid/Vue/Babel) to versions compatible with Rsbuild v2.
- Regenerate
pnpm-lock.yamlto reflect the new dependency graph/resolutions.
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Lockfile refresh reflecting @rsbuild/core@2.0.1 and associated plugin/resolution updates. |
| packages/vue-start/package.json | Bumps devDependency on @rsbuild/core to ^2.0.1. |
| packages/start-plugin-core/package.json | Bumps devDependency on @rsbuild/core to ^2.0.1. |
| packages/solid-start/package.json | Bumps devDependency on @rsbuild/core to ^2.0.1. |
| packages/react-start/package.json | Bumps peerDependencies.@rsbuild/core to ^2.0.1. |
| examples/solid/quickstart-rspack-file-based/package.json | Updates Rsbuild core + Solid/Babel plugin versions for the Solid quickstart example. |
| examples/react/quickstart-rspack-file-based/package.json | Updates Rsbuild core + React plugin versions for the React quickstart example. |
| e2e/vue-start/basic/package.json | Bumps @rsbuild/core to ^2.0.1 for the Vue Start e2e fixture. |
| e2e/vue-router/rspack-basic-virtual-named-export-config-file-based/package.json | Updates Rsbuild core + Vue/Babel/Vue-JSX plugin versions for Vue Router e2e fixture. |
| e2e/vue-router/rspack-basic-file-based/package.json | Updates Rsbuild core + Vue/Babel/Vue-JSX plugin versions for Vue Router e2e fixture. |
| e2e/solid-start/basic/package.json | Bumps @rsbuild/core to ^2.0.1 for Solid Start e2e fixture. |
| e2e/solid-router/rspack-basic-virtual-named-export-config-file-based/package.json | Updates Rsbuild core + Solid/Babel plugin versions for Solid Router e2e fixture. |
| e2e/solid-router/rspack-basic-file-based/package.json | Updates Rsbuild core + Solid/Babel plugin versions for Solid Router e2e fixture. |
| e2e/react-start/server-functions/package.json | Bumps @rsbuild/core to ^2.0.1 for React Start e2e fixture. |
| e2e/react-start/rsc/package.json | Bumps @rsbuild/core to ^2.0.1 for React Start RSC e2e fixture. |
| e2e/react-start/import-protection/package.json | Bumps @rsbuild/core to ^2.0.1 for import-protection e2e fixture. |
| e2e/react-start/hmr/package.json | Bumps @rsbuild/core to ^2.0.1 for HMR e2e fixture. |
| e2e/react-start/custom-server-rsbuild/package.json | Bumps @rsbuild/core to ^2.0.1 for custom-server rsbuild e2e fixture. |
| e2e/react-start/basic/package.json | Bumps @rsbuild/core to ^2.0.1 for basic React Start e2e fixture. |
| e2e/react-router/rspack-basic-virtual-named-export-config-file-based/package.json | Updates Rsbuild core + React plugin versions for React Router e2e fixture. |
| e2e/react-router/rspack-basic-file-based/package.json | Updates Rsbuild core + React plugin versions for React Router e2e fixture. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
packages/solid-start/package.json:128
@rsbuild/corewas updated indevDependencies, but this package still declares@rsbuild/coreas^2.0.0inpeerDependencies(later in the file). If 2.0.1 is the required minimum for the SSR/no-HTML behavior fix, bump the peer range to^2.0.1so consumers on 2.0.0 are prompted to upgrade.
"devDependencies": {
"@rsbuild/core": "^2.0.1",
"@tanstack/intent": "^0.0.14",
"@tanstack/router-utils": "workspace:*",
"@types/node": ">=20",
"vite": "*"
packages/start-plugin-core/package.json:104
- This updates the
devDependenciesto@rsbuild/core@^2.0.1, butpeerDependenciesstill allow@rsbuild/core@^2.0.0(later in the file). If plugin-core depends on the 2.0.1 behavior change, bump the peer range to^2.0.1to avoid consumers staying on 2.0.0.
"devDependencies": {
"@rsbuild/core": "^2.0.1",
"@types/babel__code-frame": "^7.0.6",
"@types/babel__core": "^7.20.5",
"@types/picomatch": "^4.0.2",
"vite": "*",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Nx Cloud has identified a flaky task in your failed CI:
Since the failure was identified as flaky, the solution is to rerun CI. Because this branch comes from a fork, it is not possible for us to push directly, but you can rerun by pushing an empty commit:
git commit --allow-empty -m "chore: trigger rerun"
git push
🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.
🎓 Learn more about Self-Healing CI on nx.dev
Merging this PR will not alter performance
Comparing 
Footnotes
|
chenjiahan
force-pushed
the
chenjiahan/update_rsbuild_v2.0.1
branch
from
0609dad to
31ae933
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@rsbuild/core^2.0.1(https://github.com/web-infra-dev/rsbuild/releases/tag/v2.0.1).Why
Rsbuild 2.0.1 includes web-infra-dev/rsbuild#7534, which fixes dev server URL printing when HTML generation is disabled. This is needed for SSR apps because Rsbuild now prints a fallback URL even when no HTML routes are generated.
Summary by CodeRabbit