Skip to content

docs: Fix server function middleware prop#7262

Merged
schiller-manuel merged 1 commit intoTanStack:mainfrom
abraj:patch-1
Apr 25, 2026
Merged

docs: Fix server function middleware prop#7262
schiller-manuel merged 1 commit intoTanStack:mainfrom
abraj:patch-1

Conversation

@abraj
Copy link
Copy Markdown
Contributor

@abraj abraj commented Apr 25, 2026

Server function middleware's .client() and .server() methods do not expose request argument.

Summary by CodeRabbit

  • Documentation
    • Refined the middleware creation example in the React framework guide to clarify the parameters available in the async callback function.

Server function middleware's `.client()` and `.server()` methods do not expose `request` argument.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b13a4ba1-9713-4aaf-8334-fb434fc685ac

📥 Commits

Reviewing files that changed from the base of the PR and between b732c8a and 83e0ac1.

📒 Files selected for processing (1)
  • docs/start/framework/react/guide/middleware.md

📝 Walkthrough

Walkthrough

Updated a React middleware documentation example by removing the request parameter from the async callback's destructuring while retaining the next and context parameters and the overall middleware flow.

Changes

Cohort / File(s) Summary
React Middleware Documentation
docs/start/framework/react/guide/middleware.md
Modified code example to remove request parameter from destructured async callback parameters in the middleware client function.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰✨ A doc tweak here, a param to drop,
The middleware guide now flows just right,
No request cluttering the view,
Just next and context shining through,
Hopping toward clarity, our work is done! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly references the specific documentation fix: removing the incorrect request parameter from the server function middleware .client() method example.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the documentation Everything documentation related label Apr 25, 2026
@schiller-manuel schiller-manuel merged commit 66dbff6 into TanStack:main Apr 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Everything documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants