[PATCH] JKXR/OpenJO: fix Traditional Chinese Big5 rendering and GUI selection - #36
Open
hsz0566 wants to merge 1 commit into
Open
[PATCH] JKXR/OpenJO: fix Traditional Chinese Big5 rendering and GUI selection#36hsz0566 wants to merge 1 commit into
hsz0566 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Team Beef Studios,
I would like to submit a Traditional Chinese rendering fix for the Jedi
Outcast mode in JKXR.
The patch is based on Team Beef JKXR commit:
9c0967a070a8251079023bde08ef9309cd6cde3fJKXR's OpenJO code uses
sp_languageto select Jedi Outcast STRIP strings, sosp_language 5correctly selectsTEXT_LANGUAGE6. However, the renderer'slanguage enum and Asian font cache still use the Jedi Academy
se_languagepath. The JK2 character decoder also calls language helpers that inspect
se_language.This causes two inconsistent states:
drawn incorrectly.
The attached patch unifies the JK2 renderer around
sp_language:GetLanguageEnum()maps JK2's numericsp_languageto Korean, Taiwanese,Japanese, or Western.
se_language->modificationCount.JK2SP_CheckForLanguageUpdates()aftersp_languagechanges, so STRIP strings and renderer decoding switch together.
Taiwanese = 5, allowing users to select Traditional Chinese withoutmanually editing a CFG file.
screen, matching the official v1.1.28 APK behavior.
Validation performed:
34, NDK
26.1.10909125, and Gradle 8.5.com.drbeef.jkxr, version1.1.28, ARM64 ABI.libopenjk_jo.so,librd-gles-jo_arm.so, and the generic OpenXR loader.git diff --checkand forward/reversegit apply --checkpass.TEXT_LANGUAGE6entries and all four Taiwanese font pages.Chinese text correctly with
sp_language 5.That first headset test exposed a separate live-switching issue: changing from
Traditional Chinese to English changed renderer decoding before the JK2 STRIP
package was reloaded. The patch now also fixes the JK2 UI update call. The
revised source builds successfully; repeated
Traditional Chinese -> English -> Traditional Chinese switching is the final
on-headset regression test requested for the updated APK.
The revised APK also restores the official v1.1.28 screen-layer condition for
2D in-game cinematics. Current main made that condition depend on
vr_immersive_cinematics, whose default is enabled; this could present theopening video directly in the viewer's field of view instead of on the
distance-adjusted quad screen.
The source patch is the intended submission. The test APK was signed only for
local validation and does not need to be distributed with the pull request.
Attachments:
0001-jkxr-fix-traditional-chinese-big5-rendering.patchTESTING.mdquest3-traditional-chinese-test.jpgThank you for reviewing the patch.
JACoders/OpenJK#1346
Best regards,

Song / hsz0566
0001-jkxr-fix-traditional-chinese-big5-rendering.patch
TESTING.md