Skip to content

fix: default preferHls to true on Safari #4236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnpc wants to merge 3 commits into
base: master
Choose a base branch
from
+5 −2
Open

fix: default preferHls to true on Safari #4236

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d78af6
fix: default preferHls to true on Safari
johnpc May 17, 2026
ccdb66e
chore: add explanatory comments for Safari HLS default
johnpc May 17, 2026
ea61761
style: fix comment indentation
johnpc May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/components/VideoPlayer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,8 @@ async function loadVideo() {
streams.push(...props.video.videoStreams);

const MseSupport = window.MediaSource !== undefined || window.ManagedMediaSource !== undefined;
// Safari has limited MSE/DASH support, so we default to native HLS playback.
const isSafari = /^((?!chrome|android).)*safari/i.test(navigator.userAgent);

const lbry = null;

Expand All @@ -600,7 +602,7 @@ async function loadVideo() {
props.video.audioStreams.length > 0 &&
!lbry &&
MseSupport &&
!getPreferenceBoolean("preferHls", false)
!getPreferenceBoolean("preferHls", isSafari)
) {
if (!props.video.dash) {
const dash = (await import("../utils/DashUtils.js")).generate_dash_file_from_formats(
Expand Down Expand Up @@ -638,7 +640,8 @@ async function loadVideo() {
return response.headers.get("Content-Type");
});
mime = contentType;
} else if (props.video.dash && !getPreferenceBoolean("preferHls", false)) {
// Safari defaults to HLS due to limited MSE/DASH support (see isSafari above).
} else if (props.video.dash && !getPreferenceBoolean("preferHls", isSafari)) {
uri = props.video.dash;
mime = "application/dash+xml";
} else if (props.video.hls) {
Expand Down
Loading