Skip to content

Warning fixes for clang build #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madebr wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Warning fixes for clang build #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a92d82
Fix LLVM warning: expression result unused [-Wunused-value] (expanded…
madebr May 20, 2026
e8b8293
Fix -Wenum-compare warning: comparison of different enumeration types…
madebr May 20, 2026
552b54e
Fix -Wenum-compare: comparison of different enumeration types 'SBServ…
madebr May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/gamespy/gsplatformutil.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,16 @@ unsigned int gsiGetResolvedIP(GSIResolveHostnameHandle handle);
///////////////////////////////////////////////////////////////////////////////
// Get rid of compiler warnings when parameters are never used
// (Mainly used in sample apps and callback for platform switches)
#if (defined(__MWERKS__) && !defined(_NITRO)) || defined(WIN32)
#if (defined(__MWERKS__) && !defined(_NITRO))
#define GSI_UNUSED(x) x
#elif defined(_PS2) || defined(_NITRO) || defined(_PS3) || defined(_MACOSX)
#define GSI_UNUSED(x) \
{ \
void* y = &x; \
y = NULL; \
}
#elif defined(_PSP)
#define GSI_UNUSED(x) (void)x;
#elif defined(_PSP) || defined(_WIN32)
#define GSI_UNUSED(x) (void)x

#else
#define GSI_UNUSED(x)
Expand Down
2 changes: 1 addition & 1 deletion src/gp/gpiconnect.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ static GPResult gpiSendLogin(GPConnection* connection, GPIConnectData* data)
gpiAppendIntToBuffer(connection, &iconnection->outputBuffer, iconnection->partnerID);
gpiAppendStringToBuffer(connection, &iconnection->outputBuffer, "\\response\\");
gpiAppendStringToBuffer(connection, &iconnection->outputBuffer, response);
if (iconnection->firewall == GP_FIREWALL)
if (iconnection->firewall == GPITrue)
gpiAppendStringToBuffer(connection, &iconnection->outputBuffer, "\\firewall\\1");
gpiAppendStringToBuffer(connection, &iconnection->outputBuffer, "\\port\\");
gpiAppendIntToBuffer(connection, &iconnection->outputBuffer, iconnection->peerPort);
Expand Down
2 changes: 1 addition & 1 deletion src/gp/gpisearch.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,7 +841,7 @@ static GPResult gpiProcessSearch(GPConnection* connection, GPIOperation* operati

// Start a new operation if they want more matches.
///////////////////////////////////////////////////
if ((more == GP_MORE) && (arg.more == GP_MORE))
if ((more == GPITrue) && (arg.more == GP_MORE))
CHECK_RESULT(gpiProfileSearch(connection,
data->nick,
data->uniquenick,
Expand Down
2 changes: 1 addition & 1 deletion src/serverbrowsing/sb_serverbrowsing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ static SBError WaitForTriggerUpdate(ServerBrowser sb, SBBool viaMaster)
while (sb->triggerIP != 0 && err == sbe_noerror) {
msleep(10);
err = ServerBrowserThink(sb);
if (viaMaster && sb->list.state == sb_disconnected) //we were supposed to get from master, and it's disconnected
if (viaMaster && sb->list.state == sl_disconnected) //we were supposed to get from master, and it's disconnected
break;
}
return err;
Expand Down
Loading