Skip to content

fix perspective matrix math error #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vitaminac wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix perspective matrix math error #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sparky-core/src/sp/maths/mat4.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "sp/sp.h"
#include "sp/sp.h"
#include "mat4.h"

#include <sstream>
Expand Down Expand Up @@ -245,7 +245,7 @@ namespace sp { namespace maths {

mat4 mat4::Perspective(float fov, float aspectRatio, float near, float far)
{
mat4 result(1.0f);
mat4 result(0.0f);

float q = 1.0f / tan(toRadians(0.5f * fov));
float a = q / aspectRatio;
Expand Down Expand Up @@ -388,4 +388,4 @@ namespace sp { namespace maths {
return result.str();
}

} }
} }