Return the auth challenge in the WWW-Authenticate when auth fails#1387
Open
KeesV wants to merge 5 commits intoThreeMammals:developfrom
Open
Return the auth challenge in the WWW-Authenticate when auth fails#1387KeesV wants to merge 5 commits intoThreeMammals:developfrom
KeesV wants to merge 5 commits intoThreeMammals:developfrom
Conversation
|
Same problem for Access-Control-Allow-Origin ?? |
Member
|
Hi Kees! Could you Sync fork please? So, your develop branch is outdated! |
raman-m
force-pushed
the
dev-return-auth-challenge-on-401
branch
from
40f5d8e to
0e5ab4e
Compare
Member
raman-m
added
feature
Author
|
hey @raman-m! Thanks for revitalizing this PR. It's great to see some activity here. |
raman-m
force-pushed
the
dev-return-auth-challenge-on-401
branch
from
a5b94fd to
9564e2c
Compare
Member
|
Hello @KeesV ! |
raman-m
force-pushed
the
dev-return-auth-challenge-on-401
branch
from
e99b633 to
34eb955
Compare
raman-m
added
proposal
raman-m
force-pushed
the
develop
branch
7 times, most recently
from
b0cdbd6 to
fa54613
Compare
raman-m
force-pushed
the
develop
branch
6 times, most recently
from
c216cdf to
b458f0f
Compare
raman-m
force-pushed
the
develop
branch
22 times, most recently
from
908d84f to
0678e7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes / New Feature
Perform Challenge on failed authentication, and return the generated WWW-Authenticate header in the upstream response.
Proposed Changes
AuthenticationMiddleware.cs: perform a challenge whenever authentication fails. This generates aWWW-Authenticateheader on the response.httpContext.Responsethat is available inAuthenticationMiddleware.csis recreated/overwritten further down the pipeline, so we need to preserve the generatedWWW-Authenticateheader somewhere. For now, I've put it in thehttpContext.Items(suggestions on how to do this in a better way are highly appreciated).WWW-Authenticateheader on the response inResponderMiddleware.cs.