Opt-in to set Connection:Close on downstream requests#1441
Open
bjartekh wants to merge 6 commits intoThreeMammals:developfrom
Open
Opt-in to set Connection:Close on downstream requests#1441bjartekh wants to merge 6 commits intoThreeMammals:developfrom
bjartekh wants to merge 6 commits intoThreeMammals:developfrom
Conversation
Author
|
Build failed, probably fixed by #1436 ? |
stefancruz
added a commit
to stefancruz/Ocelot
that referenced
this pull request
Dec 22, 2022
Conflicts: src/Ocelot/Requester/HttpClientBuilder.cs Cherry picked from ThreeMammals#1441
Member
|
Please do the following:
|
raman-m
force-pushed
the
feature/connection-close-opt-in
branch
from
d562ced to
05d0c97
Compare
raman-m
added
feature
Member
|
@bjartekh Hi Bjarte! I see that develop branch in your fork is too old. Is this PR related to an issue in backlog? |
raman-m
requested review from
RaynaldM,
abooraja,
anktsrkr,
binarymash,
geffzhang,
jps,
philproctor,
raman-m,
sharpn,
thiagoloureiro,
wast and
yangzhongke
RaynaldM
approved these changes
Aug 24, 2023
raman-m
force-pushed
the
feature/connection-close-opt-in
branch
from
05d0c97 to
b0b7f66
Compare
RaynaldM
reviewed
Apr 8, 2024
raman-m
force-pushed
the
feature/connection-close-opt-in
branch
from
b0b7f66 to
00469fc
Compare
…onClose = ConnectionClose ) in order to prevent persistent connections.
raman-m
force-pushed
the
feature/connection-close-opt-in
branch
from
2ec9ff1 to
b0879ea
Compare
Member
|
@bjartekh, are you available? Could you please continue working on your pull request? |
raman-m
force-pushed
the
develop
branch
14 times, most recently
from
c216cdf to
b458f0f
Compare
raman-m
force-pushed
the
develop
branch
6 times, most recently
from
1544d9b to
4bd354b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes / New Feature #
ConnectionClose: true|falseunderGlobalConfigurationor perRoutein the Ocelot configuration files.Proposed Changes
Side note: When benchmarking this on Azure Kubernetes Service (AKS), we observed that we got a higher throughput when running with Connnection:Close than using the
Ocelot.Provider.Kubernetespackage (which queries the Kubernetes API prior to sending each request). This is one scenario where this PR is beneficial.