Skip to content

#657 Ability to set UseDefaultCredentials per route#1521

Open
Sacrilege wants to merge 4 commits intoThreeMammals:developfrom
Sacrilege:develop
Open

#657 Ability to set UseDefaultCredentials per route#1521
Sacrilege wants to merge 4 commits intoThreeMammals:developfrom
Sacrilege:develop

Conversation

@Sacrilege
Copy link
Copy Markdown

@Sacrilege Sacrilege commented Sep 22, 2021 •
edited by raman-m
Loading

Closes #657

Support setting WebClient.UseDefaultCredentials per route if needed.

Docs

This was referenced Sep 22, 2021
Closed
Open
@clintonbale
Copy link
Copy Markdown

clintonbale commented Jul 4, 2022

Would be nice to get this merged in. Very useful PR.

@Sacrilege
Copy link
Copy Markdown
Author

Sacrilege commented Aug 8, 2022 •
edited
Loading

What will it take to get this merged in to main?
@TomPallister

stefancruz added a commit to stefancruz/Ocelot that referenced this pull request Dec 22, 2022
@stefancruz
Merge branch 'develop@Sacrilege' into develop
f16dc0b 
Cherry picked from ThreeMammals#1521
@raman-m
Copy link
Copy Markdown
Member

raman-m commented May 16, 2023

@Sacrilege Hi Troy!
Could you resolve merge conflicts please?
And what issue is this PR related to?

@raman-m raman-m added invalid Not actually an issue waiting Waiting for answer to question or feedback from issue raiser labels May 16, 2023
@raman-m raman-m marked this pull request as draft May 16, 2023 17:33
@raman-m raman-m marked this pull request as ready for review July 11, 2023 11:53
@raman-m raman-m added proposal Proposal for a new functionality in Ocelot and removed invalid Not actually an issue waiting Waiting for answer to question or feedback from issue raiser labels Jul 11, 2023
@raman-m raman-m self-requested a review July 11, 2023 11:57
@raman-m
Copy link
Copy Markdown
Member

raman-m commented Aug 28, 2023

The feature branch has been rebased onto ThreeMammals:develop successfully!
Welcome to code review!

@raman-m
Copy link
Copy Markdown
Member

raman-m commented Aug 28, 2023

@Sacrilege commented on Aug 8, 2022

I hope, merging will happen soon... 🤣

@raman-m raman-m changed the title added ability to set UseDefaultCredentials per route Ability to set UseDefaultCredentials per route Aug 28, 2023
@raman-m raman-m requested review from RaynaldM, Z-byte-prog, binarymash, geffzhang, jps and omdahl and removed request for Z-byte-prog and omdahl August 28, 2023 17:07
@raman-m
Copy link
Copy Markdown
Member

raman-m commented Apr 16, 2024

The branch has been rebased onto release/24.0 with top commit 59b63ea !

@raman-m raman-m self-assigned this Apr 25, 2024
@raman-m
Copy link
Copy Markdown
Member

raman-m commented Apr 26, 2024 •
edited
Loading

@ggnaegi commented on April 3:

Mocking UseDefaultCredentials in an acceptance test on Linux hosts could be quite a pain...

Indeed, it can be challenging. However, we could set up a Windows build machine as a Docker image and direct CircleCI to execute the Windows build by downloading the image with the Windows OS from Docker Hub.
Have you encountered similar issues in your development?

Roadmap

  • Write all tests and verify them locally using the Visual Studio IDE on Windows OS. Ensure all tests pass.
  • Conduct initial builds on CircleCI using our existing ocelot2/circleci-build image with Linux OS aka Alpine 3.xx. It's likely that some tests will fail.
  • Develop a new Docker image based on Windows OS and upload it to the ocelot2 account. All three .NET SDKs must be preinstalled.
  • Modify the existing build.cake script and/or CircleCI configuration in the repository to detect Windows build scenarios and dynamically create the necessary Windows OS image container. This may present a DevOps challenge, but CircleCI workflows should offer some functionality to select the desired Docker image based on a condition.
  • Achieve a successful build on CircleCI with all checks passing.

Links

@raman-m
Copy link
Copy Markdown
Member

raman-m commented Apr 26, 2024

TODO

  • Expand unit testing, particularly for the MessageInvokerPool class
  • Conduct acceptance testing, including trials on a Windows machine

@ggnaegi
Copy link
Copy Markdown
Collaborator

ggnaegi commented Apr 26, 2024

TODO

  • Expand unit testing, particularly for the MessageInvokerPool class
  • Conduct acceptance testing, including trials on a Windows machine

So, you're expecting that quality level from our side and you merged some stuff this week out of the blue...

Ok fine then.

@raman-m raman-m changed the base branch from release/24.0 to develop June 13, 2024 10:15
@raman-m raman-m mentioned this pull request Jul 17, 2024
Closed
@raman-m raman-m added Oct'24 October 2024 release and removed 2023 Annual 2023 release labels Oct 9, 2024
@raman-m raman-m modified the milestones: Annual 2023, October'24 Oct 9, 2024
@raman-m raman-m added Summer'25 Summer 2025 release and removed Oct'24 October 2024 release labels Oct 26, 2024
@raman-m raman-m modified the milestones: October'24, Autumn'24 Oct 26, 2024
@raman-m
Copy link
Copy Markdown
Member

raman-m commented Nov 19, 2024

@ggnaegi Ups! Yet another rebase is needed! 😄
You want this feature, right? You're assigned to have some pair programming fun.

@raman-m
Copy link
Copy Markdown
Member

raman-m commented Dec 4, 2024

New Docker images based on Windows OS

Testing of Dev SSL certificates is required!

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jan 15, 2026

Coverage Status

coverage: 93.508% (+0.005%) from 93.503%
when pulling c52324d on Sacrilege:develop
into 9fc4e78 on ThreeMammals:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raman-m raman-m raman-m requested changes

@ggnaegi ggnaegi Awaiting requested review from ggnaegi

+3 more reviewers

@RaynaldM RaynaldM RaynaldM approved these changes

@Z-byte-prog Z-byte-prog Z-byte-prog approved these changes

@omdahl omdahl omdahl approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

@Sacrilege Sacrilege

@ggnaegi ggnaegi

Labels

feature A new feature high High priority proposal Proposal for a new functionality in Ocelot Spring'26 Spring 2026 release

Projects

None yet

Milestone

Spring'26

Development

Successfully merging this pull request may close these issues.

Ocelot not working with a Windows Authentication

10 participants

@Sacrilege @clintonbale @raman-m @pank789 @ggnaegi @tobiashoeft @coveralls @RaynaldM @Z-byte-prog @omdahl