Skip to content

#2327 Handle null service name in RoundRobin constructor #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SharaawyMohamed wants to merge 3 commits into from
+1 −1
Closed

#2327 Handle null service name in RoundRobin constructor #2350

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b62661
Fix: Handle null service name in RoundRobin constructor
SharaawyMohamed Dec 28, 2025
2b04f06
Merge branch 'develop' into fix/roundrobin-null-service-name
raman-m Jan 21, 2026
fce8d61
Merge branch 'develop' into fix/roundrobin-null-service-name
raman-m Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Ocelot/LoadBalancer/Balancers/RoundRobin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public RoundRobin(Func<Task<List<Service>>> services, string serviceName)
{
ArgumentNullException.ThrowIfNull(services);
_servicesDelegate = services;
_serviceName = serviceName;
_serviceName = serviceName?? string.Empty;
Copy link
Copy Markdown
Member

@raman-m raman-m Dec 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, is this really the bug fix? 🤣
It doesn’t seem related to the .NET SDK version. Can it be reproduced in .NET 9?

Copy link
Copy Markdown
Author

@SharaawyMohamed SharaawyMohamed Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the CI tests failing when all tests pass successfully on my local machine?

Copy link
Copy Markdown
Member

@raman-m raman-m Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't warry, the build is green now. Use "Re-run job" button.

Why are the CI tests failing when all tests pass successfully on my local machine?

Yes, tests pass reliably locally and remain stable in the CI environment. A few CPU-sensitive tests might occasionally fail even on local runs, but overall, the tests are optimized to perform well in both environments.
The fact is, we have many tests in Ocelot Core that run parallel logic and are sensitive to thread synchronization. Syncing threads can be unpredictable, but usually, a simple re-run does the trick.

_leasing = new();
}

Expand Down
Loading