Skip to content

#2341 AcceptanceTests project xUnit v3 migration#2357

Closed
methran1304 wants to merge 4 commits intoThreeMammals:developfrom
methran1304:mgs25/acceptancetests-xunitv3-migration
Closed

#2341 AcceptanceTests project xUnit v3 migration#2357
methran1304 wants to merge 4 commits intoThreeMammals:developfrom
methran1304:mgs25/acceptancetests-xunitv3-migration

Conversation

@methran1304
Copy link
Copy Markdown
Contributor

@methran1304 methran1304 commented Feb 2, 2026

Closes #2341

This PR introduces xUnit v2 to v3 package upgrade for AcceptanceTests project only.

Proposed Changes

  • Added xunit.v3 package reference.
  • Removed xunit v2.9.3.
  • Removed xunit.SkippableFact as xUnit v3 has native support for skipping tests.
  • Replaced Skip.If() with Assert.SkipWhen().
  • Replaced Skip.IfNot() with Assert.SkipUnless().
  • Updated Xunit.Abstractions to Xunit namespace (moved in v3)
  • Improved test clarity by adding required reason string to skip assertions.

Docs: Migration v2 to v3

@methran1304 methran1304 marked this pull request as ready for review February 2, 2026 17:46
@methran1304 methran1304 changed the title Mgs25/acceptancetests xunitv3 migration #2341 AcceptanceTests project xUnit v3 migration Feb 2, 2026
@raman-m
Copy link
Copy Markdown
Member

raman-m commented Feb 3, 2026

Please move this code to the previous PR #2356 by cherry-picking the commits from the feature branch into the PR #2356 branch. Once that is done, go ahead and close this PR.

@raman-m raman-m marked this pull request as draft February 3, 2026 10:38
@raman-m raman-m added this to the .NET 10 milestone Feb 3, 2026
@raman-m
Copy link
Copy Markdown
Member

raman-m commented Feb 3, 2026

Check the latest build status❗
The code in the feature branch isn't compiling due to build errors. How were the migrated projects tested if they couldn't be built? I've marked this PR as a draft.

@methran1304
Copy link
Copy Markdown
Contributor Author

methran1304 commented Feb 3, 2026

Check the latest build status❗ The code in the feature branch isn't compiling due to build errors. How were the migrated projects tested if they couldn't be built? I've marked this PR as a draft.

It was due a change in UnitTests project as I used find all and replace in the whole solution instead of just this project by mistake. As for the testing, I didn't try to build UnitTests project due to the scope of the changes. It's fixed now in this branch, I'll cherry-pick the commits into #2356 and close this now.

@methran1304 methran1304 closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate testing projects to xUnit.net v3

2 participants