Skip to content

#2354 Follow-up: Redesign PollKube discovery using PeriodicTimer#2358

Merged
raman-m merged 10 commits intodevelopfrom
2354-follow-up-2
Feb 25, 2026
Merged

#2354 Follow-up: Redesign PollKube discovery using PeriodicTimer#2358
raman-m merged 10 commits intodevelopfrom
2354-follow-up-2

Conversation

@raman-m
Copy link
Copy Markdown
Member

@raman-m raman-m commented Feb 10, 2026

Follow up #2354

Proposed Changes

  • Added the Dispose pattern for logging and Kube polling
  • Fixed xUnit1051 warnings, which is a best practice when writing xUnit tests after migrating to the xUnit v3 framework
  • ❗Redesigned the PollKube discovery provider to utilize PeriodicTimer, which was introduced in .NET 8
  • Temporarily disabled PollKube acceptance tests since the work is in progress

@raman-m raman-m added this to the .NET 10 milestone Feb 10, 2026
@raman-m raman-m self-assigned this Feb 10, 2026
@raman-m raman-m added Service Discovery Ocelot feature: Service Discovery Kubernetes Service discovery by Kubernetes NET10 .NET 10 release labels Feb 24, 2026
@raman-m raman-m changed the title #2354 Follow up 2 #2354 Follow-up: Redesign PollKube discovery using PeriodicTimer Feb 24, 2026
@raman-m raman-m requested review from ggnaegi February 24, 2026 20:02
@raman-m
Copy link
Copy Markdown
Member Author

raman-m commented Feb 24, 2026

Hello @ggnaegi!
Please review if you have time, or at least take a look at this piece of my art 😄 I have an idea to reuse passive polling in the PollKube provider, as it was implemented by you in the PollConsul provider. I'm calling it "passive polling."

In this PR, I am working on implementing another polling strategy, aka "active polling," which is based on PeriodicTimer callbacks, replacing old Timer callbacks as proposed by Tom earlier. After the release, we could unify both polling strategies and propose a service discovery option to switch between them.

P.S. Please note that the PollKube acceptance tests have been temporarily disabled, as the provider and tests are still under development . However, I plan to release the Ocelot beta version in 1-2 days, which should be well-received by the community as it will facilitate the much-awaited migration to the .NET 10 SDK.

@raman-m raman-m merged commit 9134d61 into develop Feb 25, 2026
2 checks passed
@raman-m raman-m deleted the 2354-follow-up-2 branch February 25, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Kubernetes Service discovery by Kubernetes NET10 .NET 10 release Service Discovery Ocelot feature: Service Discovery

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant