You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello @ggnaegi!
Please review if you have time, or at least take a look at this piece of my art 😄 I have an idea to reuse passive polling in the PollKube provider, as it was implemented by you in the PollConsul provider. I'm calling it "passive polling."
In this PR, I am working on implementing another polling strategy, aka "active polling," which is based on PeriodicTimer callbacks, replacing old Timer callbacks as proposed by Tom earlier. After the release, we could unify both polling strategies and propose a service discovery option to switch between them.
P.S. Please note that the PollKube acceptance tests have been temporarily disabled, as the provider and tests are still under development . However, I plan to release the Ocelot beta version in 1-2 days, which should be well-received by the community as it will facilitate the much-awaited migration to the .NET 10 SDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #2354
Proposed Changes
Disposepattern for logging andKubepollingPollKubediscovery provider to utilizePeriodicTimer, which was introduced in .NET 8PollKubeacceptance tests since the work is in progress