fix(chatform): Do not interpret 祝 and 秘 as smiley. by nickolay168 · Pull Request #699 · TokTok/qTox

nickolay168 · 2026-03-30T04:10:06Z

I have updated the update_smileys.py script so that we can block and unblock smiley without loosing information. I have used the script for removing 祝 and 秘. See #613.

This change is

github-actions · 2026-03-30T04:10:18Z

Tip

Preview URL:

Green-Sky · 2026-05-08T15:13:17Z

What is the status of this one?

nickolay168 · 2026-05-09T01:25:07Z

What is the status of this one?

I have pushed more changes to fix static analysis errors. I think, it is ready now. The only failing test is related to Bazel issue.

Green-Sky

Looks good otherwise.

Green-Sky · 2026-05-12T06:52:23Z

I have pushed the fix, but it seems, we have issues with Codacy. Is it configured through UI (It does not seems, we have .codacy.yml)? The linter has both D212 and D213 enabled, which are mutually exclusive. There is also inconsistency in Arguments processing, that results in two errors in codacy.

I cant see "D213", but it is supposed to follow https://peps.python.org/pep-0257/#multi-line-docstrings anyway, so lets get it back to that state and then we look at the ci again.

Codacy sadly only shows the last scan for a pr.

The linter in question is Prospector btw.

nickolay168 · 2026-05-13T04:49:30Z

Prospector

I see. In have ran prospector locally and fixed the issues with Noqa.
By default prospector -D will run both D212 and D213 checks

Multi-line docstring summary should start at the first line (D212)
Multi-line docstring summary should start at the second line (D213)

I have set # noqa D213 comments to allow PEP 257 compliant docstrings.

In some places I have suppressed D407, because if the docstring contains Args:, but rthere is no Return section, it results in failure. I.e. there is no underline under Args: section; section could not contain colon., however

Args
-----
    param: description

will result in error about undocumented parameter "param", because now args is just a section, but not the Arguments description.

@Green-Sky, I have synced the PR could you please take another look?

Green-Sky · 2026-05-30T12:18:17Z

Ah, guess I forgot to submit the pending review. I will do the changes and merge.

edit: If I had the permissions to modify your branch.

Green-Sky · 2026-06-02T08:57:05Z

God what is up withy mypy now.

nickolay168 · 2026-06-03T07:05:16Z

God what is up withy mypy now.

It looks like all static analyzers are passing now.

nickolay168 temporarily deployed to netlify March 30, 2026 04:10 — with GitHub Actions Inactive

github-actions Bot added the bug Bug fix for the user, not a fix to a build script label Mar 30, 2026

nickolay168 force-pushed the nickolay168/fix_smileys branch from bcb1695 to 9f47bd8 Compare March 30, 2026 04:48

nickolay168 temporarily deployed to netlify March 30, 2026 04:48 — with GitHub Actions Inactive

nickolay168 force-pushed the nickolay168/fix_smileys branch from 9f47bd8 to 4d27e31 Compare March 30, 2026 05:30

nickolay168 temporarily deployed to netlify March 30, 2026 05:30 — with GitHub Actions Inactive

nickolay168 force-pushed the nickolay168/fix_smileys branch from 4d27e31 to 74d2c16 Compare March 30, 2026 06:07

nickolay168 temporarily deployed to netlify March 30, 2026 06:07 — with GitHub Actions Inactive

nickolay168 force-pushed the nickolay168/fix_smileys branch from 74d2c16 to 43bf715 Compare April 4, 2026 07:58

nickolay168 had a problem deploying to netlify April 4, 2026 07:58 — with GitHub Actions Error

nickolay168 force-pushed the nickolay168/fix_smileys branch from 43bf715 to 144b208 Compare April 4, 2026 08:06

nickolay168 temporarily deployed to netlify April 4, 2026 08:07 — with GitHub Actions Inactive

nickolay168 force-pushed the nickolay168/fix_smileys branch from 144b208 to 4e413d3 Compare April 4, 2026 08:23

nickolay168 temporarily deployed to netlify April 4, 2026 08:23 — with GitHub Actions Inactive

nickolay168 force-pushed the nickolay168/fix_smileys branch from 4e413d3 to 942ed73 Compare May 9, 2026 00:34

nickolay168 temporarily deployed to netlify May 9, 2026 00:34 — with GitHub Actions Inactive

nickolay168 force-pushed the nickolay168/fix_smileys branch from 942ed73 to 30b98a1 Compare May 9, 2026 00:57

nickolay168 had a problem deploying to netlify May 9, 2026 00:57 — with GitHub Actions Error

nickolay168 force-pushed the nickolay168/fix_smileys branch from 30b98a1 to 8da424e Compare May 9, 2026 01:05

nickolay168 temporarily deployed to netlify May 9, 2026 01:05 — with GitHub Actions Inactive

nickolay168 marked this pull request as ready for review May 9, 2026 01:23

Green-Sky added this to the v1.18.5 milestone May 9, 2026

Green-Sky requested changes May 9, 2026

View reviewed changes

Comment thread smileys/update_smileys.py Outdated

nickolay168 force-pushed the nickolay168/fix_smileys branch from 8da424e to 8b18c32 Compare May 9, 2026 23:15

nickolay168 had a problem deploying to netlify May 9, 2026 23:15 — with GitHub Actions Error

nickolay168 force-pushed the nickolay168/fix_smileys branch from 8b18c32 to 3f2ba70 Compare May 9, 2026 23:20

nickolay168 had a problem deploying to netlify May 9, 2026 23:20 — with GitHub Actions Error

Green-Sky reviewed May 10, 2026

View reviewed changes

Comment thread smileys/update_smileys.py Outdated

nickolay168 force-pushed the nickolay168/fix_smileys branch from 4b154c9 to 3a2537a Compare May 10, 2026 23:25

nickolay168 temporarily deployed to netlify May 10, 2026 23:25 — with GitHub Actions Inactive

nickolay168 requested a review from Green-Sky May 10, 2026 23:45

nickolay168 force-pushed the nickolay168/fix_smileys branch from 3a2537a to 32fb32c Compare May 13, 2026 03:32

nickolay168 had a problem deploying to netlify May 13, 2026 03:32 — with GitHub Actions Error

nickolay168 force-pushed the nickolay168/fix_smileys branch from 32fb32c to cf89ed4 Compare May 13, 2026 03:38

nickolay168 temporarily deployed to netlify May 13, 2026 03:39 — with GitHub Actions Inactive

nickolay168 force-pushed the nickolay168/fix_smileys branch from cf89ed4 to daa4d27 Compare May 13, 2026 04:18

nickolay168 had a problem deploying to netlify May 13, 2026 04:18 — with GitHub Actions Error

nickolay168 force-pushed the nickolay168/fix_smileys branch from daa4d27 to 371a750 Compare May 13, 2026 04:26

nickolay168 had a problem deploying to netlify May 13, 2026 04:27 — with GitHub Actions Error

nickolay168 force-pushed the nickolay168/fix_smileys branch from 371a750 to 6282853 Compare May 13, 2026 04:32

nickolay168 temporarily deployed to netlify May 13, 2026 04:32 — with GitHub Actions Inactive

nickolay168 force-pushed the nickolay168/fix_smileys branch from 6282853 to a8f181e Compare May 19, 2026 02:48

nickolay168 temporarily deployed to netlify May 19, 2026 02:48 — with GitHub Actions Inactive

Green-Sky reviewed May 30, 2026

View reviewed changes

Comment thread smileys/update_smileys.py Outdated

nickolay168 force-pushed the nickolay168/fix_smileys branch from a8f181e to 038841a Compare May 31, 2026 02:24

nickolay168 had a problem deploying to netlify May 31, 2026 02:24 — with GitHub Actions Error

nickolay168 force-pushed the nickolay168/fix_smileys branch from 038841a to 7d4d64c Compare May 31, 2026 02:26

nickolay168 had a problem deploying to netlify May 31, 2026 02:26 — with GitHub Actions Error

nickolay168 force-pushed the nickolay168/fix_smileys branch from 7d4d64c to a475761 Compare May 31, 2026 02:27

nickolay168 had a problem deploying to netlify May 31, 2026 02:27 — with GitHub Actions Error

nickolay168 force-pushed the nickolay168/fix_smileys branch from a475761 to 1cfccc9 Compare May 31, 2026 02:29

fix(chatform): Do not interpret 祝 and 秘 as smileys.

3e4afac

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(chatform): Do not interpret 祝 and 秘 as smiley.#699

fix(chatform): Do not interpret 祝 and 秘 as smiley.#699
nickolay168 wants to merge 1 commit into
TokTok:masterfrom
nickolay168:nickolay168/fix_smileys

nickolay168 commented Mar 30, 2026 •

edited by iphydf

Loading

Uh oh!

github-actions Bot commented Mar 30, 2026 •

edited

Loading

Uh oh!

Green-Sky commented May 8, 2026

Uh oh!

nickolay168 commented May 9, 2026

Uh oh!

Green-Sky left a comment

Uh oh!

Uh oh!

Uh oh!

Green-Sky commented May 12, 2026

Uh oh!

nickolay168 commented May 13, 2026 •

edited

Loading

Uh oh!

Green-Sky commented May 30, 2026 •

edited

Loading

Uh oh!

Uh oh!

Green-Sky commented Jun 2, 2026

Uh oh!

nickolay168 commented Jun 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

nickolay168 commented Mar 30, 2026 • edited by iphydf Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Green-Sky commented May 8, 2026

Uh oh!

nickolay168 commented May 9, 2026

Uh oh!

Green-Sky left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Green-Sky commented May 12, 2026

Uh oh!

nickolay168 commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Green-Sky commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Green-Sky commented Jun 2, 2026

Uh oh!

nickolay168 commented Jun 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

nickolay168 commented Mar 30, 2026 •

edited by iphydf

Loading

github-actions Bot commented Mar 30, 2026 •

edited

Loading

nickolay168 commented May 13, 2026 •

edited

Loading

Green-Sky commented May 30, 2026 •

edited

Loading