Skip to content

New features and fixes#614

Open
RickyB505 wants to merge 6 commits intoTomGrobbe:supplemental-permissions-pilotfrom
RickyB505:supplemental-permissions-pilot
Open

New features and fixes#614
RickyB505 wants to merge 6 commits intoTomGrobbe:supplemental-permissions-pilotfrom
RickyB505:supplemental-permissions-pilot

Conversation

@RickyB505
Copy link
Copy Markdown
Contributor

No description provided.

@RickyB505 RickyB505 force-pushed the supplemental-permissions-pilot branch from 95003db to eb04052 Compare April 21, 2026 20:56
Comment thread vMenu/CommonFunctions.cs

#region Main Spawn Vehicle Function
public static int lastSpawnTime = 0;
public static int spawnTime = ConfigManager.GetSettingsInt(ConfigManager.Setting.vmenu_vehicle_spawn_delay, 5) * 1000; // make convar
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// make convar

Todo?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope just left in while writing it ill remove it

Comment thread vMenu/CommonFunctions.cs

if (!vehicle.Model.IsTrain) // to be extra fucking safe
{
// workaround of retarded feature above:
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving this block means this comment makes no sense.
Because it was relating to line 1408:

//vehicle.Speed = speed; // retarded feature that randomly breaks for no fucking reason

So you can probably just cleanup both the commented out line and the comment here.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And why did you move it up here btw? Now it gets it's speed before the vehicle mods, and the RPM is set (delayed) after the velocity.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was moved so if your not spawning in the vehicle it doesn't keep the momentum

Comment thread vMenu/MainMenu.cs
}
}), false);

RegisterCommand("vMenu:DV", new Action<dynamic, List<dynamic>, string>(async (source, args, rawCommand) =>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this command just trigger existing functionality to delete the vehicle? I'm assuming the option for the permission VODelete already has all the necessary checks implemented?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it uses the default delete vehicle functionality partly, but it also has a raycast element to it so you dont need to be inside it to delete it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants