Skip to content

feat(cluster): reap orphaned dev clusters on worktree removal #3128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daryllimyt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(cluster): reap orphaned dev clusters on worktree removal #3128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .config/wt.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,9 @@
# Post-Create: Install dependencies after worktree creation
[pre-start]
deps = "UV_LINK_MODE=symlink uv sync --group admin & pnpm -C frontend i & wait"

# Pre-Remove: tear down this worktree's clusters so they are not orphaned.
# `rm --all` is non-interactive and exits 0 when nothing is running, so it can
# never block worktree removal.
[pre-remove]
cluster = "./scripts/cluster rm --all || true"

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Do not delete volumes from the pre-remove hook

Whenever a developer removes a worktree with wt, this hook invokes rm --all, whose implementation runs docker compose ... down --volumes without asking whether the worktree's database and other persisted state may be destroyed. Worktree removal is not explicit confirmation of volume data loss, so keep the hook non-destructive or require a separate confirmed cleanup action.

AGENTS.md reference: AGENTS.md:L65-L67

Useful? React with 👍 / 👎.

Loading
Loading