fix(executor): mark pool backend experimental, auto selects ephemeral - #3146
Merged
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to 8497da2. Security Overview
Detected Code Changes
|
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55629a7658
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Marks the
poolexecutor backend as experimental and not production ready, and stopsautofrom silently selecting it.autonow resolves toephemeralwhen nsjail is available (previouslypool). Fallback todirectis unchanged.poollogs a warning at backend resolution.ExecutorBackendType,PoolBackend, and theTRACECAT__EXECUTOR_BACKENDconfig docstrings now carry the experimental caveat.poolandtestbackends are removed from the docs entirely:docs/self-hosting/security.mdxrecommendsephemeralfor production, and the backend table, Kubernetes guide, and env-var reference now only documentdirect,ephemeral, andauto. Both remain valid (undocumented) config values.Why
Pool workers are long-lived and import from registry cache paths that in-process cache leases cannot see. Bounded cache eviction (#3139) therefore has to exempt tarball-bearing entries under the pool backend, which means the executor registry cache can grow without bound in pool mode. Until pool has worker-aware cache ownership (per-worker leases or worker draining/recycling), it should not be selected implicitly or recommended for production.
Notes
TRACECAT__EXECUTOR_BACKEND=autowith nsjail available switch from warm pool workers to cold ephemeral sandboxes (~100-200ms → ~4000ms per action) in exchange for bounded cache behavior and full per-action isolation. Explicitpoolconfig is untouched.TRACECAT__EXECUTOR_BACKEND; the default remainsdirect.