fix(dsl): structure trigger validation errors - #3152
Open
tracerat[bot] wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActionErrorInfomapTRIGGERexpression contextTesting
uv run pytest --confcutdir=tests/unit tests/unit/test_dsl_workflow_error_unwrap.py -quv run ruff check tracecat/dsl/workflow.py tests/unit/test_dsl_workflow_error_unwrap.py tests/temporal/test_workflows.pyuv run ruff format --check tracecat/dsl/workflow.py tests/unit/test_dsl_workflow_error_unwrap.py tests/temporal/test_workflows.pyuv run basedpyright tracecat/dsl/workflow.py tests/unit/test_dsl_workflow_error_unwrap.py tests/temporal/test_workflows.pyuv run pre-commit run --files tracecat/dsl/workflow.py tests/unit/test_dsl_workflow_error_unwrap.py tests/temporal/test_workflows.pyThe existing Temporal trigger-validation regression assertion was tightened for the new envelope and will run in CI; the local host does not provide the required service stack.
Summary by cubic
Standardizes trigger input validation errors by wrapping them in an action-compatible
ActionErrorInfoenvelope withTRIGGERcontext. Prevents tuple/list detail payloads from leaking to workflow error handlers while preserving field-level errors.ActionErrorInfomap inApplicationError.details(root ref<root>, typeValidationError).childrenwithexpr_contextTRIGGER(e.g.,default_number,ticket_key), using the original pydantic errortypeand message.ActionErrorInfoAdapter.Written for commit 8e1d63a. Summary will update on new commits.