fix(executor): terminate action process groups - #3159
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
✅ No security or compliance issues detected. Reviewed everything up to fe89081. Security Overview
Detected Code Changes
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7cbc86c20d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
7cbc86c to
18be338
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18be338ed0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93cfd41bec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
93cfd41 to
fe89081
Compare

Summary
This is the correctness prerequisite for #3139: active action processes must be gone before their registry-artifact lease is released and the cache entry becomes eligible for eviction.
Scope
This contains ordinary descendants that remain in the action's process group. Deliberately detached sessions are outside the unsafe fallback's contract; full hostile-code isolation requires nsjail or PID-namespace support. Reaping orphaned grandchildren from a PID-1 worker is separate container-init hygiene because zombies cannot execute against or hold file descriptors into the leased artifact.
Testing
uv run pytest tests/unit/test_registry_artifacts.py tests/unit/test_action_runner.py tests/unit/test_unsafe_pid_executor.py -q(58 passed)31 passed)20 passed)0 errors, 0 warnings)LOC breakdown
Related Issues
ENG-1568