perf(registry): deduplicate manifests in batch queries - #3169
Open
daryllimyt wants to merge 2 commits into
Open
Conversation
daryllimyt
marked this pull request as ready for review
July 31, 2026 23:05
|
✅ No security or compliance issues detected. Reviewed everything up to 87b0e98. Security Overview
Detected Code Changes
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f9604d6b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jordan-umusu
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The batched action query joined each index row to the complete registry-version manifest. A representative request therefore transferred the same multi-megabyte JSON document once per action even though PostgreSQL execution itself was fast.
Impact
Manifest transfer and validation now scale with the number of distinct selected registry versions instead of the number of requested actions. Organization precedence, custom-registry entitlement filtering, and result behavior are preserved.
Validation
uv run pytest tests/unit/test_registry_actions_custom_entitlement.py -q— 6 passeduv run ruff checkanduv run ruff format --checkon changed filesuv run basedpyright— 0 diagnosticsLOC breakdown
Tracking
ENG-1575
Summary by cubic
Deduplicates registry manifests in batched action queries and adds a safe retry when versions change mid-read. This reduces transfer and validation cost while preserving org precedence and entitlements; addresses ENG-1575.
Written for commit 87b0e98. Summary will update on new commits.