refactor(temporal): remove obsolete PydanticAI plugin - #3203
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to 4071928. Security Overview
Detected Code Changes
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
925bd09 to
e4b0fd5
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
TracecatPydanticAIPluginand its worker/test wiringWhy
Agent execution now runs through
run_agent_activityrather than PydanticAI's Temporal durable-execution API. The remaining plugin was legacy wiring that preserved the same converter already supplied byconnect_to_temporal(), added PydanticAI-specific workflow exception types that are no longer raised, and depended on PydanticAI's private_workflow_runner.PydanticAI remains in use outside Temporal and is not removed as a dependency.
Impact
No user-facing behavior change is intended. DSL and agent workers connect to Temporal without registering the obsolete PydanticAI plugin, while retaining Tracecat's existing converter and sandbox configuration.
Validation
uv run pytest tests/unit/test_worker_activity_registration.py tests/temporal/test_agent_config_sandbox_parity.py -q— 19 passeduv run ruff check tracecat/agent/worker.py tracecat/dsl/worker.py tests/conftest.py tests/temporal/test_agent_config_sandbox_parity.pyuv run ruff format --check tracecat/agent/worker.py tracecat/dsl/worker.py tests/conftest.py tests/temporal/test_agent_config_sandbox_parity.pyuv run basedpyright tracecat/agent/worker.py tracecat/dsl/worker.py tests/conftest.py tests/temporal/test_agent_config_sandbox_parity.pyLOC breakdown
Summary by cubic
Removed the obsolete
TracecatPydanticAIPluginand updated Temporal workers to initialize without plugins while keeping Tracecat’s data converter and sandbox setup. No user-facing changes.tracecat/dsl/plugins.pyand all references toTracecatPydanticAIPluginin agent, DSL workers, and tests.get_temporal_client()withoutplugins=, preserving the existing data converter and sandbox runners.connect_to_temporal()configures Tracecat’s data converter (PydanticPayloadConverterwith compression viaCompressionPayloadCodec) and passes an emptypluginslist.Written for commit 4071928. Summary will update on new commits.