Skip to content

refactor(temporal): remove obsolete PydanticAI plugin - #3203

Open
daryllimyt wants to merge 2 commits into
mainfrom
agent/remove-temporal-pydantic-ai-plugin
Open

refactor(temporal): remove obsolete PydanticAI plugin#3203
daryllimyt wants to merge 2 commits into
mainfrom
agent/remove-temporal-pydantic-ai-plugin

Conversation

@daryllimyt

@daryllimyt daryllimyt commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the unused TracecatPydanticAIPlugin and its worker/test wiring
  • keep the existing Tracecat Temporal data converter and sandbox runners as the direct configuration
  • verify every registered DSL and agent workflow initializes with a plugin-free Temporal client

Why

Agent execution now runs through run_agent_activity rather than PydanticAI's Temporal durable-execution API. The remaining plugin was legacy wiring that preserved the same converter already supplied by connect_to_temporal(), added PydanticAI-specific workflow exception types that are no longer raised, and depended on PydanticAI's private _workflow_runner.

PydanticAI remains in use outside Temporal and is not removed as a dependency.

Impact

No user-facing behavior change is intended. DSL and agent workers connect to Temporal without registering the obsolete PydanticAI plugin, while retaining Tracecat's existing converter and sandbox configuration.

Validation

  • uv run pytest tests/unit/test_worker_activity_registration.py tests/temporal/test_agent_config_sandbox_parity.py -q — 19 passed
  • uv run ruff check tracecat/agent/worker.py tracecat/dsl/worker.py tests/conftest.py tests/temporal/test_agent_config_sandbox_parity.py
  • uv run ruff format --check tracecat/agent/worker.py tracecat/dsl/worker.py tests/conftest.py tests/temporal/test_agent_config_sandbox_parity.py
  • uv run basedpyright tracecat/agent/worker.py tracecat/dsl/worker.py tests/conftest.py tests/temporal/test_agent_config_sandbox_parity.py
  • repository pre-commit hooks

LOC breakdown

Category + -
Logic 2 49
Tests 30 4

Summary by cubic

Removed the obsolete TracecatPydanticAIPlugin and updated Temporal workers to initialize without plugins while keeping Tracecat’s data converter and sandbox setup. No user-facing changes.

  • Refactors
    • Deleted tracecat/dsl/plugins.py and all references to TracecatPydanticAIPlugin in agent, DSL workers, and tests.
    • Switched to get_temporal_client() without plugins=, preserving the existing data converter and sandbox runners.
    • Added tests verifying registered workflows start without plugins and that connect_to_temporal() configures Tracecat’s data converter (PydanticPayloadConverter with compression via CompressionPayloadCodec) and passes an empty plugins list.

Written for commit 4071928. Summary will update on new commits.

Review in cubic

@daryllimyt daryllimyt added agents LLM agents engine Improvements or additions to the workflow engine refactor Refactoring labels Aug 5, 2026 — with ChatGPT Codex Connector
@daryllimyt
daryllimyt marked this pull request as ready for review August 5, 2026 20:52
@daryllimyt
daryllimyt requested a review from jordan-umusu August 5, 2026 20:52
@zeropath-ai

zeropath-ai Bot commented Aug 5, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 4071928.

Security Overview
Detected Code Changes
Change Type Relevant files
Refactor ► tests/conftest.py
    Remove TracecatPydanticAIPlugin import and usage in temporal client initialization
► tests/temporal/test_agent_config_sandbox_parity.py
    Add workflow tests without Temporal plugins and import new workflows
► tests/unit/test_temporal_client.py
    Add unit test for Temporal client data converter configuration
► tracecat/agent/worker.py
    Remove TracecatPydanticAIPlugin usage in get_temporal_client call
► tracecat/dsl/worker.py
    Remove TracecatPydanticAIPlugin import and usage in get_temporal_client call
► tracecat/dsl/plugins.py
    Delete TracecatPydanticAIPlugin file

@daryllimyt

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 925bd09aa6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@daryllimyt
daryllimyt force-pushed the agent/remove-temporal-pydantic-ai-plugin branch from 925bd09 to e4b0fd5 Compare August 6, 2026 19:38
@daryllimyt

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 4071928c3e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents LLM agents engine Improvements or additions to the workflow engine refactor Refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant