-
-
Notifications
You must be signed in to change notification settings - Fork 11.5k
Updated welcome email renderer to use custom design settings #27094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
cmraible
wants to merge
16
commits into
main
from
chris-ny-1197-use-design-settings-from-the-database-when-rendering-welcome
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
eae43bc
Used saved design settings in welcome email rendering
cmraible 93aaf3e
Fixed welcome email header image rendering
cmraible 9c29c07
Gated welcome email rendering behind labs flag
cmraible ee7773d
Reused shared registerHelpers in welcome email renderer
cmraible 897f8cb
Updated welcome email snapshots for labs-disabled path
cmraible 3b3aadf
Gated welcome email renderer changes behind labs
cmraible 8b9010d
Updated snapshot tests
cmraible 80d55e1
Duplicated welcome email integration coverage by labs flag
cmraible 637868e
Split welcome email renderer tests by labs flag
cmraible d3c7b42
Updated welcome email snapshots after rebase
cmraible 3afa747
Reduced welcome email integration test duplication
cmraible 52a60ff
Fixed welcome email snapshot flag tests
cmraible f006b84
Removed mocked welcome email service tests
cmraible 5b0cb58
Fixed welcome email content shell styling
cmraible 2f6f566
Removed send-time design settings refresh
cmraible bd22af6
Fixed welcome email design customization hooks
cmraible File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure this is the right approach here. Basically this uses the styles.hbs from newsletters directly, which includes some cruft that we don't need in welcome emails. It works, but I'm not sure how I feel about this architecturally - maybe we don't want to couple welcome emails and newsletters in this way?