Added sender details customization for welcome emails #27192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

cmraible merged 7 commits into main from NY-1164_welcome-email-sender-info

Apr 7, 2026

Merged

Fixed case-sensitive domain comparison in sender email validation

SonarQubeCloud / SonarCloud Code Analysis failed Apr 7, 2026 in 1m 57s

Quality Gate failed

Failed conditions
4.1% Duplication on New Code (required ≤ 3%)

Prefer `node:assert/strict` over `assert/strict`.

See more on https://sonarcloud.io/project/issues?id=TryGhost_Ghost&issues=AZ1koAdS6XBGhgATe2Vf&open=AZ1koAdS6XBGhgATe2Vf&pullRequest=27192

`VERIFIED_SENDER_PROPERTIES` should be a `Set`, and use `VERIFIED_SENDER_PROPERTIES.has()` to check existence or non-existence.

See more on https://sonarcloud.io/project/issues?id=TryGhost_Ghost&issues=AZ1koAXH6XBGhgATe2Vd&open=AZ1koAXH6XBGhgATe2Vd&pullRequest=27192

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=TryGhost_Ghost&issues=AZ1koAd06XBGhgATe2Vg&open=AZ1koAd06XBGhgATe2Vg&pullRequest=27192

Use 'Object.hasOwn()' instead of 'Object.prototype.hasOwnProperty.call()'.

See more on https://sonarcloud.io/project/issues?id=TryGhost_Ghost&issues=AZ1koAXH6XBGhgATe2Ve&open=AZ1koAXH6XBGhgATe2Ve&pullRequest=27192