Allow tinybird-local Docker updates to automerge#27244
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughUpdated Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/renovate.json5:
- Around line 132-141: The Renovate automerge rule for "matchPackageNames":
"tinybirdco/tinybird-local" currently allows digest bumps to auto-merge without
running Tinybird tests because the `changed_tinybird` condition only watches
ghost/core/core/server/data/tinybird/**; update the rule so it either (A)
expands the `changed_tinybird` filter to also include compose.dev.analytics.yaml
and .github/workflows/ci.yml (or a broader pattern that covers repo root
compose/workflow changes) so job_tinybird-tests will run, or (B) remove
`"automerge": true`/`"automergeType"` from this tinybird rule so Renovate PRs
require CI validation before merging.
- Around line 132-141: The renovate rule that matches tinybirdco/tinybird-local
currently allows automerge for all update types (fields: "matchDatasources",
"matchPackageNames", "automerge", "automergeType"), so restrict it by adding
"matchUpdateTypes": ["digest"] to that rule to ensure only digest updates are
auto-merged; then verify the CI gating (workflow check referenced as
changed_tinybird) will run for digest updates to the workflow/image and adjust
the workflow trigger or gating logic if needed so digest-only Renovate PRs run
the tinybird tests before automerge.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f9b0bcf2-10b8-491c-855b-22cca93f4e7e
📒 Files selected for processing (1)
.github/renovate.json5
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 147-148: The CI workflow currently uses the same changed_tinybird
output for both tests and deploy gates which causes
deploy_tinybird_staging/production to be triggered by unrelated CI or
compose-local changes; create a new output/filter named changed_tinybird_deploy
that only matches files relevant to Tinybird deployments, leave changed_tinybird
for test-related file patterns, then update wiring so job_tinybird-tests uses
changed_tinybird while deploy_tinybird_staging and deploy_tinybird_production
use changed_tinybird_deploy.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c368d132-7020-41ad-918b-cddf987350bd
📒 Files selected for processing (2)
.github/renovate.json5.github/workflows/ci.yml
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/renovate.json5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27244 +/- ##
==========================================
+ Coverage 73.46% 73.49% +0.02%
==========================================
Files 1545 1545
Lines 123686 123720 +34
Branches 14961 14973 +12
==========================================
+ Hits 90870 90922 +52
+ Misses 31819 31777 -42
- Partials 997 1021 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ref #27228 The tinybirdco/tinybird-local digest PR updates Ghost's local analytics service image in CI and compose files. Like ghost/traffic-analytics, it is an internal operational image update that can safely use PR automerge once CI has passed, so add a narrow Docker rule for that single image instead of broadening Docker automerge globally.
ref #27228 Collapse the internal Docker automerge rules into a single digest-only rule for ghost/traffic-analytics and tinybirdco/tinybird-local. At the same time, expand the CI tinybird path filter so Renovate digest bumps in compose.dev.analytics.yaml and .github/workflows/ci.yml actually run job_tinybird-tests before automerge can proceed.
CodeRabbit correctly pointed out that broadening changed_tinybird to cover the Tinybird image digest PR would also have widened the Tinybird deploy gates. Split the filter in two so CI and compose changes still run Tinybird tests, while staging/production deploys remain gated only on actual Tinybird datafile changes. Keep the combined internal Docker digest automerge rule in Renovate so traffic analytics and tinybird-local image updates stay in one narrow, digest-only lane.
cmraible
force-pushed
the
fix/renovate-automerge-tinybird-local
branch
from
2ced688 to
b594ac3
Compare
|
cmraible
left a comment
cmraible
left a comment
There was a problem hiding this comment.
Pushed a small tweak to the naming so it's a little more intuitive, otherwise LGTM!
2 participants
Summary
tinybirdco/tinybird-localDocker imageWhy this change
The
tinybirdco/tinybird-localdigest PR in #27228 updates Ghost's local analytics service image in CI and compose files. Likeghost/traffic-analytics, it is an internal operational image update that can safely use PR automerge once CI has passed.