This repository was archived by the owner on Aug 15, 2024. It is now read-only.
Fix python snippets linter issues - #955
Merged
Merged
Conversation
alexisbcc
force-pushed
the
fix-python-snippets
branch
from
December 10, 2021 14:19
f88e5bd to
96b7ee9
Compare
alexisbcc
force-pushed
the
fix-python-snippets
branch
from
December 10, 2021 16:03
96b7ee9 to
f36761e
Compare
alexisbcc
changed the base branch from
master
to
change-travis-to-GH-actions
December 10, 2021 21:12
This reverts commit f36761e.
alexisbcc
force-pushed
the
fix-python-snippets
branch
from
December 13, 2021 16:57
16b2994 to
18bf21b
Compare
alexisbcc
commented
Dec 13, 2021
| .rooms('RMXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX') \ | ||
| .recording_rules \ | ||
| .update(rules=[{"type": "include", "all": true}]) | ||
| .update(rules=[{"type": "include", "all": True}]) |
Contributor
Author
There was a problem hiding this comment.
The required type is boolean, not string.
alexisbcc
commented
Dec 13, 2021
| .rooms('RMXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX') \ | ||
| .recording_rules \ | ||
| .update(rules=[{"type": "exclude", "all": true}]) | ||
| .update(rules=[{"type": "exclude", "all": True}]) |
Contributor
Author
There was a problem hiding this comment.
The required type is boolean, not string.
alexisbcc
marked this pull request as ready for review
December 13, 2021 19:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the linter issues present in the new GH actions implementation for the python code snippets.
The new GH actions implementation is done here: #946
The tests errors are not being fixed in this PR only the linter errors.
Changes:
.github/setup/action.ymltools/snippet-testing/language_handler/python.rb