Skip to content

Add Flatpak#2023

Open
ReillyBrogan wants to merge 11 commits into
TwilitRealm:mainfrom
ReillyBrogan:cmakeAppId
Open

Add Flatpak#2023
ReillyBrogan wants to merge 11 commits into
TwilitRealm:mainfrom
ReillyBrogan:cmakeAppId

Conversation

@ReillyBrogan

Copy link
Copy Markdown
Contributor
  • Change appId on Linux to dev.twilitrealm.Dusklight
  • Install assets with cmake
  • Fix platform name (was getting set to "cmake_system_name")
  • Add flatpak

Part of #1862

Comment thread CMakeLists.txt Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we conditionally set this to .Dusklight for Linux builds and use this variable downstream instead of LINUX_APP_ID. We can also include it in our version.h.in so that SDL_SetAppMetadata can use it directly rather than the conditional logic

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken that a little bit further. The app_id is now configurable and defaults to dev.twilitrealm.Dusklight on Linux and dev.twilitrealm.dusk on all other platforms. With DUSK_PACKAGE_INSTALL all files installed use the app_id as part of their name or install location and so it should be possible for forks to change the app_id to be co-installable without any further change.

Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants