Add Flatpak#2023
Open
ReillyBrogan wants to merge 11 commits into
Open
Conversation
encounter
reviewed
Jun 8, 2026
Member
There was a problem hiding this comment.
Maybe we conditionally set this to .Dusklight for Linux builds and use this variable downstream instead of LINUX_APP_ID. We can also include it in our version.h.in so that SDL_SetAppMetadata can use it directly rather than the conditional logic
Contributor
Author
There was a problem hiding this comment.
I've taken that a little bit further. The app_id is now configurable and defaults to dev.twilitrealm.Dusklight on Linux and dev.twilitrealm.dusk on all other platforms. With DUSK_PACKAGE_INSTALL all files installed use the app_id as part of their name or install location and so it should be possible for forks to change the app_id to be co-installable without any further change.
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1862