ci(release): release refactor and revert commits as patches - #28
Merged
Conversation
#27 merged as `refactor(api):` and published nothing. The Angular preset ships releaseRules for feat, fix, perf and breaking changes only, so commit-analyzer returned "no release" and the regenerated OpenAPI client has been sitting on main while npm still serves the old one in 2.0.0. The gap was already visible in the config: release-notes-generator lists a "Code Refactoring" section, which under stock rules can only ever appear riding along with someone else's feat or fix, never on its own. Adds refactor and revert as patch through releaseRules on the commit-analyzer. They are additive — the preset's own rules still apply as the fallback — and verified against the commits since v2.0.0, which now analyze as patch rather than none. Merging this therefore also publishes 2.0.1. Corrects both docs, which stated the refactor rule as though it were stock, and now name it as a local override.
Contributor
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#27 merged as
refactor(api):and published nothing:The Angular preset ships
releaseRulesforfeat,fix,perfand breaking changes only.refactoris not among them, so the regenerated OpenAPI client — and the dropped@hey-api/client-fetchruntime dependency — has been sitting onmainwhile npm still serves the old client in 2.0.0.The gap was already visible in the config
release-notes-generatoris configured with a Code Refactoring section. Under stock rules that section can only ever appear riding along with someone else'sfeatorfix— a refactor-only change can never cut the release that would display it.The change
refactorandrevertbecome patch viareleaseRuleson the commit-analyzer. These are additive: the preset's own rules still apply as the fallback, sofeat,fix,perfandBREAKING CHANGEare untouched.Verified by running
analyzeCommitswith the real.releaserc.jsoptions against the commits sincev2.0.0:Same input under stock rules is what the release job already reported:
no release.After merge
This is a
ci:commit, so it bumps nothing itself — but merging re-runs the analysis over everything sincev2.0.0, so #27 then publishes as 2.0.1, which is the point.Docs
PUBLISHING.md and CONTRIBUTING.md both stated the
refactor→ patch rule as though it were stock behaviour. That was wrong when written; it becomes true with this commit, and both now name it as a local override rather than presenting it as the Angular default.