Skip to content

feat: handle hashed graphql entity ids #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gsteenkamp89 merged 4 commits into from
Jan 18, 2026
+6 −6
Merged

feat: handle hashed graphql entity ids #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee9c024
hash id
gsteenkamp89 Jan 15, 2026
0d01b09
fixup
gsteenkamp89 Jan 15, 2026
f208c86
fixup
gsteenkamp89 Jan 15, 2026
0b11b86
bignumber fix
gsteenkamp89 Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions helpers/voting/makePriceRequestsByKey.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,9 @@ function formatPriceRequests(priceRequests: RawPriceRequestDataT[]) {
function formatPriceRequest(
priceRequest: RawPriceRequestDataT
): PriceRequestT & VoteParticipationT & VoteResultsT {
const time =
priceRequest.time instanceof BigNumber
Copy link
Copy Markdown
Contributor Author

@gsteenkamp89 gsteenkamp89 Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the instanceof check was failing so the value was not being converted to a number

? priceRequest.time.toNumber()
: priceRequest.time;
const time = BigNumber.isBigNumber(priceRequest.time)
? priceRequest.time.toNumber()
: priceRequest.time;
const timeMilliseconds = time * 1000;
const timeAsDate = new Date(timeMilliseconds);
const identifier = priceRequest.identifier;
Expand Down
5 changes: 3 additions & 2 deletions helpers/voting/makeUniqueKeyForVote.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { BigNumber } from "ethers";
import { BigNumber, utils } from "ethers";

export function makeUniqueKeyForVote(
decodedIdentifier: string,
Expand All @@ -8,5 +8,6 @@ export function makeUniqueKeyForVote(
if (typeof time !== "number") {
time = time.toNumber();
}
return `${decodedIdentifier}-${time}-${ancillaryData}`;
const ancillaryDataHash = utils.keccak256(utils.toUtf8Bytes(ancillaryData));
return `${decodedIdentifier}-${time}-${ancillaryDataHash}`;
}