Add Translations#2325
Open
Yago004 wants to merge 9 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds/updates UI localization across Mojolicious templates and booking error messages, alongside new/updated English, Catalan, and Spanish gettext entries.
Changes:
- Localized additional UI strings in several admin/user templates (buttons, labels, table headers).
- Localized
/bookingerror messages (including link text) via$c->stash->{i18n}->localize(...). - Expanded/adjusted
en.po,ca.po, andes.powith new msgids/msgstrs and corrected some existing keys.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/ng-templates/list_next_bookings_today.html.ep | Reformatted booking warning string used as an i18n key. |
| templates/main/vm_hostdev.html.ep | Localized “Manage Host Devices” link text. |
| templates/main/upload_users.html.ep | Localized “Type” label and “Cancel” action. |
| templates/main/storage_list.html.ep | Localized storage table headers. |
| templates/main/settings_generic.html.ep | Attempted to localize dynamic settings title and “back” link. |
| templates/main/list_bases_ng.html.ep | Localized “Prepare base” button text. |
| templates/main/admin_settings.html.ep | Localized “upload” link text. |
| templates/main/admin_machines.html.ep | Localized “Machine” label in lock status row. |
| templates/main/admin_hostdev.html.ep | Localized host device editor labels (“list command”, “filter”, “Machines”). |
| script/rvd_front | Localized booking setup error strings (with embedded links). |
| lib/Ravada/I18N/es.po | Added/updated Spanish translations for newly localized strings. |
| lib/Ravada/I18N/en.po | Added/updated English msgids/msgstrs for newly localized strings. |
| lib/Ravada/I18N/ca.po | Added/updated Catalan translations for newly localized strings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| my $i18n = $c->stash->{i18n}; | ||
| return $c->render(template => '/ng-templates/error' | ||
| ,message => "Groups are required to set up bookings. Some groups where found but no members belong to them. <a href='/admin/groups'>Add new entries here.</a>" | ||
| ,message => $i18n->localize("Groups are required to set up bookings. Some groups where found but no members belong to them.") |
Comment on lines
+2919
to
2921
| ,message => $i18n->localize("Groups are required to set up bookings. No groups found.") | ||
| ."<a href='/group/new'>".$i18n->localize(" Add new entries here.")."</a>" | ||
| ); |
Comment on lines
19
to
21
| <span class="title"> | ||
| <%= $item %> | ||
| <%=l "\u$item" %> | ||
| {{<%= $item %>._old_name}} |
| msgstr "Mostrar clones" | ||
|
|
||
| msgid "This base is available for all users" | ||
| msgstr "Esta base está disponible para todos los ususarios" |
Comment on lines
+2551
to
+2553
| msgid "You can grant access to users from the users administration form:" | ||
| msgstr "Podeu concedir accés a ususaris des del formolari d'administració d'usuaris:" | ||
|
|
| <th class="list"><%=l 'Size' %></th> | ||
| <th class="list"><%=l 'Used' %></th> | ||
| <th class="list"><%=l 'Available' %></th> | ||
| <th class="list"><%=l 'Used' %> %</th> |
| <p> | ||
| <%=l 'This server has reservations for today. Machines from users out of | ||
| the booking list will be shutdown.' %> | ||
| <%=l 'This server has reservations for today. Machines from users out of the booking list will be shutdown.' %> |
|
|
||
| <a ng-show="host_devices" type="button" class="btn btn-outline-secondary" | ||
| href="/admin/hostdev/{{showmachine.type}}"><b>Manage Host Devices</b></a> | ||
| href="/admin/hostdev/{{showmachine.type}}"><b><%=l 'Manage Host Devices' %></b></a> |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
| my $i18n = $c->stash->{i18n}; | ||
| return $c->render(template => '/ng-templates/error' | ||
| ,message => "Groups are required to set up bookings. Some groups where found but no members belong to them. <a href='/admin/groups'>Add new entries here.</a>" | ||
| ,message => $i18n->localize("Groups are required to set up bookings. Some groups were found but no members belong to them.") |
| msgid "Groups are required to set up bookings. No groups found." | ||
| msgstr "Los grupos son necesarios para configurar reservas. No se han encontrado grupos." | ||
|
|
||
| msgid "Groups are required to set up bookings. Some groups where found but no members belong to them." |
| msgid "Groups are required to set up bookings. No groups found." | ||
| msgstr "Els grups son necessaris per configurar reserves. No s'han trobat grups." | ||
|
|
||
| msgid "Groups are required to set up bookings. Some groups where found but no members belong to them." |
| <div class="col-10"> | ||
| <span class="title"> | ||
| <%= $item %> | ||
| <%=l "\u$item" %> |
| msgstr "Aquest servidor té reserves per avui." | ||
|
|
||
| msgid "Machines from users out of the booking list will be shutdown." | ||
| msgstr "Les màquines d'usuaris fora de la reserva seràn aturades." |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+7
to
+8
| <%=l 'This server has reservations for today.' %> | ||
| <%=l 'Machines from users out of the booking list will be shutdown.' %> |
Comment on lines
18
to
22
| <div class="col-10"> | ||
| <span class="title"> | ||
| <%= $item %> | ||
| <%=l "\u$item" %> | ||
| {{<%= $item %>._old_name}} | ||
| </span> |
| msgid "New Storage" | ||
| msgstr "Nou emmagatzematge" | ||
|
|
||
| msgid "Unused Volumes" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added translations for english, catalan and spanish.
Description
Added requested translations, fixed some spelling errors and fixed some words that weren't being translated before.
Motivation and Context