Validate disc version as part of file selection#8
Open
lilDavid wants to merge 1 commit into
Open
Conversation
UltiNaruto
reviewed
Jun 12, 2026
|
|
||
| try: | ||
| game_version = get_version_from_iso(input_iso_path) | ||
| except FileNotFoundError: |
Owner
There was a problem hiding this comment.
it never will raise though since it's a ValueError that gets raised
Author
There was a problem hiding this comment.
ValueError is only raised if the contents of the file are invalid. The FileNotFoundError is propagated from the open() call if the file doesn't exist at all.
UltiNaruto
requested changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves validation for the disc file format into the file validator in PrimeSettings. The benefit of this is it leverages AP's existing system and doesn't copy the file if it's invalid.
The file dialog also now only shows the ".iso" file extension, so the cases of file formats other than ".iso" and ".nkit.iso" should be rarer. The checks for the other file formats are still in place, though, and I also corrected the GCZ magic number check (every source I could find, including Dolphin and Randomprime's source code, have it as the 4-byte 0xB10BC001).