Skip to content

Hide reference to ProceduralMaterial. #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Thomasch-unity3d wants to merge 4 commits into
base: master
Choose a base branch
from
+3 −93
Open

Hide reference to ProceduralMaterial. #663

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d9bf13
Hide reference to ProceduralMaterial.
Thomasch-unity3d Mar 31, 2026
e518233
remove class obsolete for the past 8 years
lopezt-unity Mar 31, 2026
1db3c2a
changelog
lopezt-unity Mar 31, 2026
5f69313
Merge branch 'master' into bugfix/remove-proceduralmaterial-reference
lopezt-unity Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Editor/EditorCore/pb_ObjectArray.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,16 @@ public T[] GetArray<T>()

for (int i = 0; i < array.Length; i++)
{
#if UNITY_6000_6_OR_NEWER
if (array[i] is T)
{
arr[i] = (T)System.Convert.ChangeType(array[i], typeof(T));
Copy link
Copy Markdown

@u-pr u-pr bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high
Using System.Convert.ChangeType for reference types (like Unity's Material, Mesh, or GameObject) will throw an InvalidCastException unless the runtime type of the object exactly matches T. It does not support casting through inheritance (for example, if array[i] is a MeshRenderer and T is Renderer).

Since the if (array[i] is T) check on line 33 already guarantees that the object is compatible with T, a direct cast is safer, more performant, and correctly handles inheritance as well as unboxing for value types.

Suggested change
arr[i] = (T)System.Convert.ChangeType(array[i], typeof(T));
arr[i] = (T)array[i];

🤖 Helpful? 👍/👎

}
else
{
arr[i] = default(T);
}
#else
if (array[i] is ProceduralMaterial)
{
arr[i] = (T)System.Convert.ChangeType(array[i], typeof(ProceduralMaterial));
Expand All @@ -44,8 +54,8 @@ public T[] GetArray<T>()
arr[i] = default(T);
}
}
#endif
}

return (T[])arr;
}

Expand Down