Skip to content

4.4.0 rc3 bug fix #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesmisson merged 3 commits into from
May 27, 2026
Merged

4.4.0 rc3 bug fix #1769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1a3905
remove redundant conditional rendering
jamesmisson May 27, 2026
b58d013
remove console log
jamesmisson May 27, 2026
46c319c
new pr
jamesmisson May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/content-handlers/iiif/extensions/uv-openseadragon-extension/ChoiceSwitchDialogue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export class ChoiceSwitchDialogue extends BaseChoiceSwitchDialogue {
});

const mobileFooterButton = extension.mobileFooterPanel?.$choiceSwitchButton;

this.$anchor =
mobileFooterButton?.is(":visible") && mobileFooterButton?.length
? mobileFooterButton
Expand Down
18 changes: 8 additions & 10 deletions src/content-handlers/iiif/extensions/uv-openseadragon-extension/Extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,16 +620,14 @@ export default class OpenSeadragonExtension extends BaseExtension<Config> {
this.footerPanel.init();
}

if (this.helper.hasChoices()) {
this.$choiceSwitchDialogue = $(
'<div class="overlay choiceSwitch" aria-hidden="true"></div>'
);
this.shell.$overlays.append(this.$choiceSwitchDialogue);
this.choiceSwitchDialogue = new ChoiceSwitchDialogue(
this.$choiceSwitchDialogue,
this.shell
);
}
this.$choiceSwitchDialogue = $(
'<div class="overlay choiceSwitch" aria-hidden="true"></div>'
);
this.shell.$overlays.append(this.$choiceSwitchDialogue);
this.choiceSwitchDialogue = new ChoiceSwitchDialogue(
this.$choiceSwitchDialogue,
this.shell
);
}

render(): void {
Expand Down
12 changes: 3 additions & 9 deletions ...tent-handlers/iiif/modules/uv-openseadragoncenterpanel-module/OpenSeadragonCenterPanel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,8 @@ export class OpenSeadragonCenterPanel extends CenterPanel<
this.hidePrevButton();
this.hideNextButton();

this.createChoiceSwitch();

this.isCreated = true;
//this.resize();

Expand All @@ -659,8 +661,6 @@ export class OpenSeadragonCenterPanel extends CenterPanel<
{ capture: true }
);

this.createChoiceSwitch();

this.extensionHost.subscribe(IIIFEvents.CLOSE_ACTIVE_DIALOGUE, () => {
this.$viewer.removeClass("dialogue-open");
});
Expand Down Expand Up @@ -773,15 +773,9 @@ export class OpenSeadragonCenterPanel extends CenterPanel<
}

createChoiceSwitch(): void {
// check for a choice on either of the displayed canvases if in 2-up view
const indices = this.extension.getPagedIndices();
const hasChoices = this.indicesIncludeChoices(indices);

if (!hasChoices) return;

this.$choiceSwitchButton = this.$rotateButton.clone();
this.$choiceSwitchButton.attr("title", this.content.layers);
this.$choiceSwitchButton.attr("aria-label", this.content.layers);
this.$choiceSwitchButton.attr("title", this.content.layers);
this.$choiceSwitchButton.switchClass("rotate", "choiceSwitch");
this.$choiceSwitchButton.attr("tabindex", 0);

Expand Down