prompt generation of backend.... post and get giving error 404 but it…#39
Open
prompt generation of backend.... post and get giving error 404 but it…#39
Conversation
… should be good once its fixed.
RLee64
reviewed
May 4, 2026
| }, []); | ||
|
|
||
| if (!sponsors) { | ||
| if (sponsors.length === 0) { |
Collaborator
There was a problem hiding this comment.
length = 0 isn't preferable (if there's no sponsors then we're stuck in an infinite loading state!)
should use !sponsors like before (and usestate defaults to null like previously)
|
|
||
| useEffect(() => { | ||
| Promise.resolve(sponsorsJsonData as SponsorsData) | ||
| fetch("http://localhost:3000/api/sponsors") |
Collaborator
There was a problem hiding this comment.
You should use axios for this, also consider adding a sponsorsApi.ts file to handle basic boilerplate (acts as a quick way to see/update the routes if the endpoint urls ever change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… should be good once its fixed.