made it runnable on 1.8.9, but still with bugs - #24
Open
Nymphet wants to merge 15 commits into
Open
Conversation
Signed-off-by: Aerin <AerinSpieler@gmail.com>
to make it compatible with mc 1.8.9, IC 2.3.2-262 ex18
…<ItemStack> stack
|
You'd just make a pr for mc 1.10.2. |
Author
|
a built binary for quick tests |
Owner
|
I haven't looked at this yet, but certainly will as soon as I start looking into 1.8+ again. Nonetheless, thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
i've been waiting for the 1.8 version of this mod since last month, but until now there are no public releases available, so i decided to build the mod from source. Since there's no build guide written for this mod, I built it with plain
but numerous build errors popped out, so I made some quick fix to make it runnable on 1.8.9. however, i'm not sure if the build fails are caused by my local environment. Maybe we can add a build guide for this project just like the README of BuildCraft?
Some of the API calls seem to be outdated so I replaced them, since there are no tests written for this mod, i'm not sure if i broke something, please review my changes, thank you.
Cheers