feat: add notification service#1
Open
iamvirul wants to merge 1 commit into
Open
Conversation
Related authentication codeNo results found above the score threshold. |
Related payment codeNo results found above the score threshold. |
VecGrep PR AnalysisNo semantically related code found in the codebase for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a notification service (
src/notifications/sender.py) with email (SMTP) and webhook delivery.This PR is intentionally structured to trigger and demonstrate all VecGrep Action PR-level workflows:
test-analyze.yml— should detect thatsender.pyis semantically related toprocessor.pyandauthentication.py(shared patterns: status enums, result dataclasses, pending→sent state machine) and post a comment automaticallytest-comment.yml— should post related auth + payment code found in the codebasetest-validate.yml— should pass all architectural checks (no raw SQL, no hardcoded credentials, auth logic exists)test-duplicate.yml— should detect similarity betweensender.pyandprocessor.py/invoice.py(shared structural patterns)Changes
src/notifications/__init__.pysrc/notifications/sender.py—create_notification(),send_email(),send_webhook(),get_notification()What to look for
Check the Actions tab and PR comments after CI runs to see VecGrep surfacing related code automatically.