chore: fix .gitignore glob to cover nested reports directories - #331
Merged
N-thnI merged 2 commits intoAug 24, 2026
Merged
Conversation
- Change `reports/*.json` to `**/reports/*.json` so the rule matches report files at any directory depth, not just the top-level ./reports/ folder. - Untrack src/audit-guard/reports/latest-scan.json which was incorrectly committed due to the shallow glob. Closes Vero-protocol#312
Contributor
|
Correction on my earlier "please ensure all checks pass" comment — that wasn't your PR's fault. The RPC Relayer Bridge Tests job was failing on Cause was on our side: #327 bumped axios to 1.x (which made I've updated your branch so it picks up the fix — CI is re-running. Apologies for the noise. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The root
.gitignore'sreports/*.jsonrule only matched the top-level./reports/path. Any nestedreports/directory (e.g.src/audit-guard/reports/) was not covered, causingsrc/audit-guard/reports/latest-scan.jsonto be tracked in version control unintentionally.Changes
.gitignore: Changedreports/*.json→**/reports/*.jsonso the glob matches report JSON files at any directory depth.src/audit-guard/reports/latest-scan.json: Removed from git tracking viagit rm --cached. The file remains on disk but is now correctly ignored.Verification
Closes #312