Skip to content

chore: fix .gitignore glob to cover nested reports directories - #331

Merged
N-thnI merged 2 commits into
Vero-protocol:mainfrom
divinemike019:chore/issue--fix-nested-reports-gitignore
Aug 24, 2026
Merged

chore: fix .gitignore glob to cover nested reports directories#331
N-thnI merged 2 commits into
Vero-protocol:mainfrom
divinemike019:chore/issue--fix-nested-reports-gitignore

Conversation

@divinemike019

Copy link
Copy Markdown
Contributor

Summary

The root .gitignore's reports/*.json rule only matched the top-level ./reports/ path. Any nested reports/ directory (e.g. src/audit-guard/reports/) was not covered, causing src/audit-guard/reports/latest-scan.json to be tracked in version control unintentionally.

Changes

  • .gitignore: Changed reports/*.json**/reports/*.json so the glob matches report JSON files at any directory depth.
  • src/audit-guard/reports/latest-scan.json: Removed from git tracking via git rm --cached. The file remains on disk but is now correctly ignored.

Verification

$ git ls-files | grep reports
reports/.gitkeep          ← intentional (kept by !reports/.gitkeep rule)

$ git check-ignore -v src/audit-guard/reports/latest-scan.json
.gitignore:4:**/reports/*.json   src/audit-guard/reports/latest-scan.json

Closes #312

- Change `reports/*.json` to `**/reports/*.json` so the rule
  matches report files at any directory depth, not just the top-level
  ./reports/ folder.
- Untrack src/audit-guard/reports/latest-scan.json which was
  incorrectly committed due to the shallow glob.

Closes Vero-protocol#312
@N-thnI

N-thnI commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Correction on my earlier "please ensure all checks pass" comment — that wasn't your PR's fault. The RPC Relayer Bridge Tests job was failing on main itself, so every open PR here inherited a red check.

Cause was on our side: #327 bumped axios to 1.x (which made headers required on a config type used in a test mock) and #321 left a duplicate variable declaration behind. Neither surfaced until #323 wired those tests into CI for the first time. Fixed in #332, now merged.

I've updated your branch so it picks up the fix — CI is re-running. Apologies for the noise.

@N-thnI
N-thnI merged commit 36ce939 into Vero-protocol:main Aug 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.gitignore's reports/*.json rule doesn't reach nested reports directories

2 participants