You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One workflow note for future PRs: this one is raised from samkay-ops:main rather than a topic branch. Could you branch off main for each piece of work (e.g. git checkout -b fix/issue-NNN-short-description) and open the PR from that branch?
Working on your fork's main is what makes these conflict — once upstream main moves, your main has diverged and can't cleanly take the update, which is exactly what's happened here. A topic branch per issue keeps each PR independent and rebaseable, and keeps your fork's main clean to sync from upstream.
Your other PRs (#365, and the dashboard ones) already do this — just worth making it the default. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #344 — a substring check skipped any line containing
fs::write(dir.join, so e.g.unsafe { ... } // fs::write(dir.joinproduced no finding.Changes
scan_filetests/test/__tests__path segments inrust_source_filesinsteadUNSAFE_BLOCKtests/are not scannedAcceptance criteria
unsafeandfs::write(dir.joinreportsUNSAFE_BLOCKCloses #344