fix: use xcat-compat initrd for Ubuntu pre-16.04.2 ppc64el in copycds#14
fix: use xcat-compat initrd for Ubuntu pre-16.04.2 ppc64el in copycds#14viniciusferrao wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8c53fd9da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| # Ubuntu pre-16.04.2 on ppc64el ships an initrd that cannot PXE boot. | ||
| # Use the netboot-capable initrd from the xcat-compat package if available. | ||
| if ($arch eq "ppc64el" and $distname =~ /^ubuntu(\d+)\.(\d+)\.?(\d*)/) |
There was a problem hiding this comment.
The compat-initrd workaround in copycd is gated by parsing $distname (/^ubuntu(\d+)\.(\d+)\.?/), but copycds -n/--name explicitly allows operators to provide a custom distro label (see xCAT-client/pods/man8/copycds.8.pod, lines 25-27). For pre-16.04.2 ppc64el media copied with a custom name, this regex check is skipped, so the broken server-ISO initrd is left in place and the provisioning failure this patch targets still occurs. The version gate should be derived from ISO metadata ($ver/$detdistname) rather than a user-overridable name.
Useful? React with 👍 / 👎.
viniciusferrao
force-pushed
the
fix/copycds-ubuntu-ppc64el-compat-initrd
branch
22 times, most recently
from
83d665a to
8bf498d
Compare
Ubuntu 14.04 through 16.04.1 shipped server ISOs with a ppc64el initrd that cannot PXE boot. When copycds detects an affected ISO, it now checks for a netboot-capable initrd from the xcat-compat package and copies it into the install path automatically. If the xcat-compat package is not installed, copycds prints a clear error message with installation instructions instead of silently leaving a broken netboot setup. Also update the mkinstall error message to reference xcat-compat. Fixes xcat2#5702
viniciusferrao
force-pushed
the
fix/copycds-ubuntu-ppc64el-compat-initrd
branch
from
8bf498d to
cabf245
Compare
1 participant
Ubuntu 14.04 through 16.04.1 shipped server ISOs with a ppc64el initrd that cannot PXE boot. Users had to manually download Canonical's mini.iso, extract the netboot initrd, and copy it into the right path.
This automates the workaround using the new
xcat-compatpackage (https://github.com/VersatusHPC/xcat-compat):copycdsdetects an affected ISO (Ubuntu ppc64el, version < 16.04.2), it checks for the compat initrd at/opt/xcat/share/xcat/netboot/ubuntu/initrd/ubuntu<ver>.ppc64el.gzThe
xcat-compatpackage is optional and only needed for legacy Ubuntu ppc64el provisioning.Fixes xcat2#5702