feat: convert tests to vitest, address timer/promise leaks#85
Open
tgriesser wants to merge 12 commits into
Open
feat: convert tests to vitest, address timer/promise leaks#85tgriesser wants to merge 12 commits into
tgriesser wants to merge 12 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on knex/knex#6413 and trying out Vitest's detectAsyncLeaks I noticed that there were leaks that seemed to be coming from the connection pool even after
destroywas calledThis converts the tests over to using
vitestto make use of thedetectAsyncLeakswhich is especially important for this library. We can test as low as Node 16 with an earlier versions of vitest (thanks @kibertoad for the suggestion there).It seems like a lot of lines, but when you look at the diff it's not bad, mostly cosmetic related to some minor differences in chai syntax.
Also by compiling with TS 5 we get rid of the generated
/// <reference types="node" />due to switching toReturnType<typeof setTimeout>|ReturnType<typeof setInterval>so@types/nodeis no longer needed as an actual dependency.