Add menu positioning settings by siimha · Pull Request #304 · Voog/design-anchorage

siimha · 2018-07-13T13:53:15Z

Close #303

entertthk · 2020-07-07T14:10:53Z

Vajaminevad tõlked settings nupule:

Mobiilse vaate seaded - Mobile view settings
Menüü asukoht - Menu positioning
Fikseeritud päises (või Lukustatud päises) - Fixed in header
Nähtav ülesse kerides - Visible when scrolling up
Koguaeg nähtav - Always visible

Added mobile menu view settings button for desktop and mobile view. Also added for script window.location.reload(); and removed overflow: scroll from css. Closes #304

siimha

Tõlked võiksid panna ka slacki keelepolitsei kanalisse ja kui sealt ka kinnitus, siis tuleks need CMSi lisada

siimha · 2020-07-13T06:51:06Z

@@ -0,0 +1,69 @@
+{% if editmode %}
+  <button class="menu-position-settings"></button>


Kasutada paremat klassi nimetust, näiteks mobile-menu-button-settings

siimha · 2020-07-13T06:53:37Z

+      var valuesObj = {};
+    {% endif %};
+
+    var productDescrptionBtn = document.querySelector('.menu-position-settings');


Kasutada muutujal paremat nimetus, näiteks mobileMenuSettingsButton

siimha · 2020-07-13T06:55:26Z

+    var SettingsEditor = new Edicy.SettingsEditor(productDescrptionBtn, {
+      menuItems: [
+        {
+          "title": "Menu positioning",


Kasutada CMSist tulevaid tõlkeid. Selleks kasutada I18 võtmeid nagu on antud PRis.

siimha · 2020-07-13T06:56:49Z

+        {
+          "title": "Menu positioning",
+          "type": "radio",
+          "key": "menu_positioning",


Lisada ka tooltip nagu antud PRis.

siimha · 2020-07-13T06:57:36Z

+      buttonActiveClass: 'settings-popover-open',
+
+      commit: function(data) {
+        siteData.set('menu_position_settings', data, {


Kasutada paremat võtme nimetust nt. mobile_menu_button_settings

siimha · 2020-07-13T08:36:34Z

    }
  };

+  var togglePositionSettingsLocation = function() {


Selle nimetus võiks olla toggleMobileMenuButtonPosition

siimha · 2020-07-13T08:36:47Z

+    var $positionSettingsMenuElement = $('.js-menu-position-settings');
+    if ($(window).width() <= 1024) {
+      $positionSettingsMenuElement.appendTo('.js-menu-main-mobile');
+      console.log($positionSettingsMenuElement, 'smaller then');


Console.log() eemaldada

siimha · 2020-07-13T08:47:06Z

+      // Title for the button.
+      buttonTitle: 'Mobiilse vaate seaded',
+      // Class for the button while Settings Editor is visible.
+      buttonActiveClass: 'settings-popover-open',


Seda klassi ei kasutata vist millekski settings-popover-open

siimha · 2020-07-13T08:50:24Z

  };

+  var togglePositionSettingsLocation = function() {
+    var $positionSettingsMenuElement = $('.js-menu-position-settings');


Selle muutja nimetus võiks olla mobileMenuButtonElement

siimha · 2020-07-13T08:51:40Z

              <button class="btn btn-js-styled js-menu-language-settings-toggle js-prevent-sideclick"></button>
            </li>
          {% endif %}
+          <li class="menu-item-cms js-menu-position-settings">{% include "menu-settings-editor" %} </li>


Selle nimetus võiks olla js-mobile-menu-button-wrapper

entertthk · 2020-07-16T11:33:48Z

Muutujate ja funktsioonide nimed parandatud. Puudu veel tooltipid ja tõlked.

siimha

Mõningased kommentaarid.

siimha · 2020-08-12T07:50:37Z

+            },
+            {
+              "titleI18n": "always_visible",
+              "value": "visible-when"


Need väärtused on vahetusse läinud:

{ "titleI18n": "always_visible", "value": "visible-when" }, { "titleI18n": "visible_when_scrolling_up", "value": "always-visible" }

siimha · 2020-08-12T07:51:00Z

          </div>

-          <div class="header-right js-header-right">
+          <div class="header-right {{ site.data.menu_position_settings.menu_positioning }}  js-header-right">


data nimetus peaks olema mobile_menu_button_settings

siimha · 2020-08-12T07:51:18Z

+        success: function() {
+          window.location.reload();
+      }
+  });


Joondus paigast.

siimha · 2020-08-12T07:51:58Z

+  <script>
+    var siteData = new Edicy.CustomData({
+      type: 'site',
+      id: {{ site.id }}


Lehe datal pole id-d

siimha · 2020-08-12T07:55:56Z

+        }
+      }
+
+      &.visible-when, {


Koma on üleliigne &.visible-when, seda tuleb kasutada vaid siis kui sihitakse ka mingit muud klassi. Võib kasutada &.visible-when. scrolling { stiilid }.

siimha · 2020-08-12T07:57:51Z

+              "value": "always-visible"
+            },
+          ],
+


Komad üleliigsed objektil ja arrayl. Liigne tühi rida.

siimha · 2020-08-12T07:58:12Z

        {% if editmode %}
          <li class="edit-btn">{% languageadd %}</li>
-        {% endif %}
+        {% endif %}       


Üleliigsed tühikud

siimha · 2020-08-12T08:00:22Z

+      }, 400);
+    } else {
+      $('.visible-when').addClass('scrolling');
+


Üleliigne tühi rida

Add menu positioning settings

765526f

siimha self-assigned this Jul 13, 2018

siimha added the feature label Jul 13, 2018

siimha mentioned this pull request Jul 13, 2018

Add settings for menu positioning #303

Open

siimha and others added 3 commits July 13, 2018 16:56

Change positioning titles

d46bc68

Change footer & header to left when menu open

3cf87b3

Merge branch 'master' into 303_menu_positioning_settings

17ac964

Mobile menu view settings button

521349f

Added mobile menu view settings button for desktop and mobile view. Also added for script window.location.reload(); and removed overflow: scroll from css. Closes #304

siimha commented Jul 13, 2020

View reviewed changes

siimha assigned entertthk and unassigned siimha Jul 13, 2020

siimha added the tested (needs work) label Jul 13, 2020

Variable and function name fixes

c58c179

entertthk added 2 commits August 11, 2020 15:47

I18n translations added

5a31cb2

Merge branch 'master' into 303_menu_positioning_settings

dc8812e

siimha commented Aug 12, 2020

View reviewed changes

Fixed bugs from prevoius comments by reviewer

404f08e

tanelj self-requested a review August 18, 2020 08:34

Removed unneccecary commas.

44e9f19

		@@ -0,0 +1,69 @@
		{% if editmode %}
		<button class="menu-position-settings"></button>

Uh oh!

Conversation

siimha commented Jul 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

entertthk commented Jul 7, 2020

Uh oh!

siimha left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

entertthk commented Jul 16, 2020

Uh oh!

siimha left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

siimha Aug 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

siimha commented Jul 13, 2018 •

edited

Loading

siimha Aug 12, 2020 •

edited

Loading