Skip to content

Redis improvements and fixes#221

Draft
frikilax wants to merge 4 commits into
devfrom
redis_ip
Draft

Redis improvements and fixes#221
frikilax wants to merge 4 commits into
devfrom
redis_ip

Conversation

@frikilax

@frikilax frikilax commented Mar 24, 2021

Copy link
Copy Markdown
Member

✨ Redis improvements and fixes

📃 Type of change

Please delete options that are not relevant.

Bug fix: non-breaking change which fixes an issue.
New feature: non-breaking change which adds functionality.

💡 Related Issue(s)

  • none

✒️ Description

Fixed

  • fbuffer: checks if key exists and is a SET (not a LIST) before potentially cleaning it at startup
  • Redis Manager: TestIsManager(ip, port) logic was inverted
  • Tests: check_start_stop did not check if filter is running properly

Added

  • Alert Manager: possibility to connect to Redis via IP:port
  • fbuffer/fconnection/fend/fsession/ftanomaly/ftest: possibility to connect to Redis via IP:port

TODO

  • update documentation
  • add tests for Redis through IP (at least in base tests)

🎯 Test Environments

FreeBSD (version)

  • Redis (version)
  • Boost (version)
  • clang++ (or g++) (version)
  • CMake (version)
  • Python (version)

Ubuntu (version)

  • Redis (version)
  • Boost (version)
  • g++ (or clang++) (version)
  • CMake (version)
  • Python (version)
  • Valgrind (version)

✔️ Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • (If new filter) I have added corresponding page to the documentation
  • (If other changes) I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

  • 🙋 I certify on my honor that all the information provided is true, and I've done all I can to deliver a high quality code

@frikilax frikilax changed the base branch from master to dev July 1, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant