Skip to content

fix(security): verify a student belongs to the run before changing their password #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hirokiterashima merged 2 commits into from
Jul 21, 2026
Merged

fix(security): verify a student belongs to the run before changing their password #332

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b5cafb
fix(security): verify a student belongs to the run before changing th…
Isaries Jul 16, 2026
88d5223
refactor(security): consolidate authorization check into isAllowed
Isaries Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...rtal/presentation/web/controllers/teacher/management/ChangeStudentPasswordController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ ResponseEntity<Map<String, Object>> changeStudentPassword(Authentication auth,
return ResponseEntityGenerator.createError(passwordService.getErrors(newStudentPassword));
}
User studentUser = userService.retrieveById(studentId);
if (!run.isStudentAssociatedToThisRun(studentUser)) {
throw new AccessDeniedException(
"User does not have permission to change this student's password");
}

@Aaron-Detre Aaron-Detre Jul 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!run.isStudentAssociatedToThisRun(studentUser)) {
throw new AccessDeniedException(
"User does not have permission to change this student's password");
}

userService.updateUserPassword(studentUser, newStudentPassword);
return ResponseEntityGenerator.createSuccess("passwordUpdated");
} else {
Expand Down
30 changes: 30 additions & 0 deletions .../presentation/web/controllers/teacher/management/ChangeStudentPasswordControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,36 @@ public void changeStudentPassword_InvalidPassword_ReturnError() throws Exception
verifyServices();
}

@Test
public void changeStudentPassword_StudentNotInRun_ThrowAccessDenied() throws Exception {
setupChangeStudentPasswordExpect();
expect(userService.isPasswordCorrect(teacher1, TEACHER_PASSWORD_CORRECT)).andReturn(true);
expect(userService.retrieveById(student2Id)).andReturn(student2);
replayServices();
try {
controller.changeStudentPassword(teacherAuth, runId1, student2Id, TEACHER_PASSWORD_CORRECT,
STUDENT_PASSWORD_VALID);
fail("Expected AccessDeniedException to be thrown");
} catch (AccessDeniedException e) {
}
verifyServices();
}

@Test
public void changeStudentPassword_TargetUserIsTeacher_ThrowAccessDenied() throws Exception {
setupChangeStudentPasswordExpect();
expect(userService.isPasswordCorrect(teacher1, TEACHER_PASSWORD_CORRECT)).andReturn(true);
expect(userService.retrieveById(teacher2Id)).andReturn(teacher2);
replayServices();
try {
controller.changeStudentPassword(teacherAuth, runId1, teacher2Id, TEACHER_PASSWORD_CORRECT,
STUDENT_PASSWORD_VALID);
fail("Expected AccessDeniedException to be thrown");
} catch (AccessDeniedException e) {
}
verifyServices();
}

@Test
public void changeStudentPassword_validTeacherPassword_ChangeStudentPassword() throws Exception {
setupChangeStudentPasswordExpect();
Expand Down
Loading